BugFix: Added logic to netbox_dcim to determine if interface is part of a vc device or not (#111)

Author: FragmentedPacket

plugins/module_utils/netbox_dcim.py

@@ -90,6 +90,17 @@ def run(self):
         object_query_params = self._build_query_params(endpoint_name, data)
         self.nb_object = self._nb_endpoint_get(nb_endpoint, object_query_params, name)
 
+        # This is logic to handle interfaces on a VC
+        if self.endpoint == "interfaces":
+            if self.nb_object:
+                if self.nb_object.device:
+                    device = nb_endpoint.get(self.nb_object.device.id)
+                    if (
+                        device["virtual_chassis"]
+                        and self.nb_object.device.id != self.data["device"]
+                    ):
+                        self.object = None
+
         if self.state == "present":
             self._ensure_object_exists(nb_endpoint, endpoint_name, name, data)
 

tests/integration/integration-tests.yml

@@ -339,7 +339,7 @@
           - test_five['interface']['enabled'] == false
           - test_five['interface']['form_factor'] == 1000
           - test_five['interface']['mgmt_only'] == false
-          - test_five['interface']['lag'] == 14
+          - test_five['interface']['lag'] == 15
           - test_five['interface']['mode'] == 100
           - test_five['interface']['mtu'] == 1600
 
@@ -428,10 +428,33 @@
           - test_eight['interface']['enabled'] == false
           - test_eight['interface']['form_factor'] == 1000
           - test_eight['interface']['mgmt_only'] == false
-          - test_eight['interface']['lag'] == 14
+          - test_eight['interface']['lag'] == 15
           - test_eight['interface']['mode'] == 100
           - test_eight['interface']['mtu'] == 1600
 
+    - name: "9 - Create interface on VC child"
+      netbox_device_interface:
+        netbox_url: "http://localhost:32768"
+        netbox_token: "0123456789abcdef0123456789abcdef01234567"
+        data:
+          device: Test Nexus Child One
+          name: Ethernet1/1
+          form_factor: 1000Base-T (1GE)
+        state: present
+      register: test_nine
+
+    - name: "9 - ASSERT"
+      assert:
+        that:
+          - test_nine is changed
+          - test_nine['msg'] == "interface Ethernet1/1 created"
+          - test_nine['diff']['before']['state'] == 'absent'
+          - test_nine['diff']['after']['state'] == 'present'
+          - test_nine['interface']['name'] == "Ethernet1/1"
+          - test_nine['interface']['device'] == 5
+          - test_nine['interface']['enabled'] == true
+          - test_nine['interface']['form_factor'] == 1000
+
 ##
 ##
 ### NETBOX_IP_ADDRESS
@@ -615,7 +638,7 @@
           - test_eight['msg'] == "ip_address 10.10.1.30/16 created"
           - test_eight['ip_address']['address'] == "10.10.1.30/16"
           - test_eight['ip_address']['family'] == 4
-          - test_eight['ip_address']['interface'] == 1
+          - test_eight['ip_address']['interface'] == 2
           - test_eight['ip_address']['nat_inside'] == 7
           - test_eight['ip_address']['vrf'] == 1
 
@@ -640,7 +663,7 @@
           - test_nine['msg'] == "ip_address 10.10.200.30/16 created"
           - test_nine['ip_address']['address'] == "10.10.200.30/16"
           - test_nine['ip_address']['family'] == 4
-          - test_nine['ip_address']['interface'] == 2
+          - test_nine['ip_address']['interface'] == 3
 
     - name: "10 - Create IP address on GigabitEthernet2 - test100 - State: new"
       netbox_ip_address:
@@ -664,7 +687,7 @@
           - test_ten['msg'] == "ip_address 10.10.0.1/16 created"
           - test_ten['ip_address']['address'] == "10.10.0.1/16"
           - test_ten['ip_address']['family']['value'] == 4
-          - test_ten['ip_address']['interface']['id'] == 2
+          - test_ten['ip_address']['interface']['id'] == 3
 
     - name: "11 - Create IP address on GigabitEthernet2 - test100 - State: present"
       netbox_ip_address:
@@ -706,7 +729,7 @@
           - not test_twelve['changed']
           - test_twelve['msg'] == "ip_address 192.168.100.2/24 already exists"
           - test_twelve['ip_address']['address'] == "192.168.100.2/24"
-          - test_twelve['ip_address']['interface'] == 2
+          - test_twelve['ip_address']['interface'] == 3
 
     - name: "13 - Duplicate - 192.168.100.2/24"
       netbox_ip_address:
@@ -745,7 +768,7 @@
           - test_fourteen['msg'] == "ip_address 10.188.1.100/24 created"
           - test_fourteen['ip_address']['address'] == "10.188.1.100/24"
           - test_fourteen['ip_address']['family'] == 4
-          - test_fourteen['ip_address']['interface'] == 3
+          - test_fourteen['ip_address']['interface'] == 4
 
     - name: "15 - Create IP address with no mask - State: Present"
       netbox_ip_address:

tests/integration/netbox-deploy.py

@@ -189,6 +189,13 @@
 ### Device variables to be used later on
 test100 = nb.dcim.devices.get(name="test100")
 
+# Create VC, assign member, create initial interface
+created_vcs = nb.dcim.virtual_chassis.create({"master": 4})
+nexus_child = nb.dcim.devices.get(5)
+nexus_child.update({"virtual_chassis": 1, "vc_position": 1})
+nexus = nb.dcim.devices.get(4)
+nexus.update({"vc_position": 0})
+nb.dcim.interfaces.create({"device": 4, "name": "Ethernet1/1", "type": 1000})
 
 ## Create Interfaces
 dev_interfaces = [