BugFix: Fix device type slug (#77)

Author: FragmentedPacket

plugins/module_utils/netbox_dcim.py

@@ -74,6 +74,8 @@ def run(self):
         # Used for msg output
         if data.get("name"):
             name = data["name"]
+        elif data.get("model") and not data.get("slug"):
+            name = data["model"]
         elif data.get("slug"):
             name = data["slug"]
 

plugins/module_utils/netbox_utils.py

@@ -381,6 +381,7 @@
     "cluster_groups",
     "cluster_types",
     "device_roles",
+    "device_types",
     "ipam_roles",
     "rack_groups",
     "rack_roles",

plugins/modules/netbox_device_type.py

@@ -51,8 +51,9 @@
       slug:
         description:
           - The slug of the device type. Must follow slug formatting (URL friendly)
+          - If not specified, it will slugify the model
           - ex. test-device-type
-        required: true
+        required: false
       part_number:
         description:
           - The part number of the device type
@@ -164,8 +165,8 @@ def main():
                 required=True,
                 options=dict(
                     manufacturer=dict(required=False, type="raw"),
-                    model=dict(required=False, type="raw"),
-                    slug=dict(required=True, type="str"),
+                    model=dict(required=True, type="raw"),
+                    slug=dict(required=False, type="str"),
                     part_number=dict(required=False, type="str"),
                     u_height=dict(required=False, type="int"),
                     is_full_depth=dict(required=False, type="bool"),
@@ -180,7 +181,7 @@ def main():
         )
     )
 
-    required_if = [("state", "present", ["slug"]), ("state", "absent", ["slug"])]
+    required_if = [("state", "present", ["model"]), ("state", "absent", ["model"])]
 
     module = NetboxAnsibleModule(
         argument_spec=argument_spec, supports_check_mode=True, required_if=required_if

tests/integration/integration-tests.yml

@@ -1846,7 +1846,7 @@
         netbox_token: 0123456789abcdef0123456789abcdef01234567
         data:
           slug: test-device-type
-          model: ws-test-3750
+          model: "ws-test-3750"
           manufacturer: Test Manufacturer
         state: present
       register: test_two
@@ -1895,7 +1895,7 @@
         netbox_url: http://localhost:32768
         netbox_token: 0123456789abcdef0123456789abcdef01234567
         data:
-          slug: test-device-type
+          model: test-device-type
         state: absent
       register: test_four
 
@@ -1912,7 +1912,7 @@
         netbox_url: http://localhost:32768
         netbox_token: 0123456789abcdef0123456789abcdef01234567
         data:
-          slug: test-device-type
+          model: "Test Device Type"
         state: absent
       register: test_five
 
@@ -1921,7 +1921,28 @@
         that:
           - not test_five['changed']
           - test_five['device_type'] == None
-          - test_five['msg'] == "device_type test-device-type already absent"
+          - test_five['msg'] == "device_type Test Device Type already absent"
+
+    - name: "DEVICE_TYPE 6: Without Slug"
+      netbox_device_type:
+        netbox_url: http://localhost:32768
+        netbox_token: 0123456789abcdef0123456789abcdef01234567
+        data:
+          model: "WS Test 3850"
+          manufacturer: Test Manufacturer
+        state: present
+      register: test_six
+
+    - name: "DEVICE_TYPE 6: ASSERT - Without Slug"
+      assert:
+        that:
+          - test_six is changed
+          - test_six['diff']['before']['state'] == "absent"
+          - test_six['diff']['after']['state'] == "present"
+          - test_six['device_type']['slug'] == "ws-test-3850"
+          - test_six['device_type']['model'] == "WS Test 3850"
+          - test_six['device_type']['manufacturer'] == 3
+          - test_six['msg'] == "device_type WS Test 3850 created"
 
 ##
 ##