Bugfix: Allow Integers for IDs to be passed into lists. (#409)

Author: FragmentedPacket

plugins/module_utils/netbox_utils.py

@@ -840,6 +840,11 @@ def _find_ids(self, data, user_query_params):
                             temp_dict = self._build_query_params(
                                 k, data, child=norm_data
                             )
+                        # If user passes in an integer, add to ID list to id_list as user
+                        # should have passed in a tag ID
+                        elif isinstance(list_item, int):
+                            id_list.append(list_item)
+                            continue
                         query_id = self._nb_endpoint_get(nb_endpoint, temp_dict, k)
                         if query_id:
                             id_list.append(query_id.id)

tests/integration/netbox-deploy.py

@@ -41,7 +41,8 @@ def make_netbox_calls(endpoint, payload):
 
 # Create tags used in future tests
 if nb_version >= version.parse("2.9"):
-    create_tags = nb.extras.tags.create(
+    create_tags = make_netbox_calls(
+        nb.extras.tags,
         [
             {"name": "First", "slug": "first"},
             {"name": "Second", "slug": "second"},
@@ -53,7 +54,7 @@ def make_netbox_calls(endpoint, payload):
             {"name": "tagB", "slug": "tagb"},
             {"name": "tagC", "slug": "tagc"},
             {"name": "Updated", "slug": "updated"},
-        ]
+        ],
     )
 
 # ORDER OF OPERATIONS FOR THE MOST PART

tests/integration/targets/regression-latest/tasks/main.yml

@@ -148,9 +148,10 @@
           status: "Staged"
           asset_tag: "Null"
           tags:
-            - slug: second
-            - slug: third
-            - slug: first
+            # Changed these for issue #407 to be IDs
+            - 2
+            - 3
+            - 1
       register: test_seven
 
     - name: "5 - Assert added tag - Tests #242 is fixed"

tests/integration/targets/regression-v2.9/tasks/main.yml

@@ -148,9 +148,10 @@
           status: "Staged"
           asset_tag: "Null"
           tags:
-            - slug: second
-            - slug: third
-            - slug: first
+            # Changed these for issue #407 to be IDs
+            - 2
+            - 3
+            - 1
       register: test_seven
 
     - name: "5 - Assert added tag - Tests #242 is fixed"