Unmask "packaging module missing" error (#1126)

rostskadat · web-flow · commit 3455821bc924 · 2023-12-10T20:22:07.000+01:00
When the packaging module is missing the error will be masked because we try to use self.module before it has been initialized
diff --git a/plugins/module_utils/netbox_dcim.py b/plugins/module_utils/netbox_dcim.py
@@ -63,7 +63,7 @@
 class NetboxDcimModule(NetboxModule):
     def __init__(self, module, endpoint):
         if not HAS_PACKAGING:
-            self.module.fail_json(
+            module.fail_json(
                 msg=missing_required_lib("packaging"), exception=PACKAGING_IMPORT_ERROR
             )
         super().__init__(module, endpoint)

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@`
`63`	`63`	`class NetboxDcimModule(NetboxModule):`
`64`	`64`	`def __init__(self, module, endpoint):`
`65`	`65`	`if not HAS_PACKAGING:`
`66`		`- self.module.fail_json(`
	`66`	`+ module.fail_json(`
`67`	`67`	`msg=missing_required_lib("packaging"), exception=PACKAGING_IMPORT_ERROR`
`68`	`68`	`)`
`69`	`69`	`super().__init__(module, endpoint)`