Skip to content

Commit 073e687

Browse files
authored
Fixes #616 Ensure netbox_virtual_machine is idempotent on 2.11 (#633)
* Adjust vcpu return on pre-3.0 NetBox
1 parent d8f2b23 commit 073e687

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

plugins/module_utils/netbox_utils.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1144,7 +1144,7 @@ def _update_netbox_object(self, data):
11441144
serialized_nb_obj["tags"] = set(serialized_nb_obj["tags"])
11451145
updated_obj["tags"] = set(data["tags"])
11461146

1147-
# Ensure idempotency for site on version pre-3.0
1147+
# Ensure idempotency for site and virtual machine on version pre-3.0
11481148
version_pre_30 = self._version_check_greater("3.0", self.version)
11491149
if (
11501150
serialized_nb_obj.get("latitude")
@@ -1159,6 +1159,9 @@ def _update_netbox_object(self, data):
11591159
):
11601160
updated_obj["longitude"] = str(data["longitude"])
11611161

1162+
if serialized_nb_obj.get("vcpus") and data.get("vcpus") and version_pre_30:
1163+
updated_obj["vcpus"] = "{0:.2f}".format(data["vcpus"])
1164+
11621165
if serialized_nb_obj == updated_obj:
11631166
return serialized_nb_obj, None
11641167
else:

0 commit comments

Comments
 (0)