From 9aa356b9ad5af5c6af4025f0f22f5b31d860f0d2 Mon Sep 17 00:00:00 2001 From: Siddhant Sadangi Date: Tue, 15 Oct 2024 13:04:17 +0200 Subject: [PATCH 1/4] Remove iterables from `log_config` value type hints --- src/neptune_scale/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/neptune_scale/__init__.py b/src/neptune_scale/__init__.py index 2bc91f16..3cb43c75 100644 --- a/src/neptune_scale/__init__.py +++ b/src/neptune_scale/__init__.py @@ -442,7 +442,7 @@ def log_metrics( """ self.log(step=step, timestamp=timestamp, metrics=data) - def log_configs(self, data: Optional[Dict[str, Union[float, bool, int, str, datetime, list, set]]] = None) -> None: + def log_configs(self, data: Optional[Dict[str, Union[float, bool, int, str, datetime]]] = None) -> None: """ Logs the specified metadata to a Neptune run. From 934ca99e089a530b320a506f31cbec761ced6c82 Mon Sep 17 00:00:00 2001 From: Siddhant Sadangi Date: Wed, 16 Oct 2024 13:50:58 +0200 Subject: [PATCH 2/4] Remove `list` and `set` from `log`'s `config` types --- src/neptune_scale/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/neptune_scale/__init__.py b/src/neptune_scale/__init__.py index 3cb43c75..495c6083 100644 --- a/src/neptune_scale/__init__.py +++ b/src/neptune_scale/__init__.py @@ -516,7 +516,7 @@ def log( self, step: Optional[Union[float, int]] = None, timestamp: Optional[datetime] = None, - configs: Optional[Dict[str, Union[float, bool, int, str, datetime, list, set]]] = None, + configs: Optional[Dict[str, Union[float, bool, int, str, datetime]]] = None, metrics: Optional[Dict[str, Union[float, int]]] = None, tags_add: Optional[Dict[str, Union[List[str], Set[str]]]] = None, tags_remove: Optional[Dict[str, Union[List[str], Set[str]]]] = None, From d7ac895dcce96dc150fc2852780d5a2b0e3663be Mon Sep 17 00:00:00 2001 From: Siddhant Sadangi Date: Wed, 16 Oct 2024 13:54:27 +0200 Subject: [PATCH 3/4] Update metadata_splitter.py --- src/neptune_scale/core/metadata_splitter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/neptune_scale/core/metadata_splitter.py b/src/neptune_scale/core/metadata_splitter.py index 2aec1ea7..c2018926 100644 --- a/src/neptune_scale/core/metadata_splitter.py +++ b/src/neptune_scale/core/metadata_splitter.py @@ -43,7 +43,7 @@ def __init__( run_id: str, step: Optional[Union[int, float]], timestamp: datetime, - fields: Dict[str, Union[float, bool, int, str, datetime, list, set]], + fields: Dict[str, Union[float, bool, int, str, datetime]], metrics: Dict[str, float], add_tags: Dict[str, Union[List[str], Set[str]]], remove_tags: Dict[str, Union[List[str], Set[str]]], From 157772b79fa7c60bc40ab1df98b003928c53ca12 Mon Sep 17 00:00:00 2001 From: Siddhant Sadangi Date: Wed, 16 Oct 2024 13:59:05 +0200 Subject: [PATCH 4/4] Removed `list` and `set` from allowed types for `config.values()` --- src/neptune_scale/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/neptune_scale/__init__.py b/src/neptune_scale/__init__.py index 495c6083..15e64e09 100644 --- a/src/neptune_scale/__init__.py +++ b/src/neptune_scale/__init__.py @@ -548,7 +548,7 @@ def log( verify_collection_type("`tags_add` keys", list(tags_add.keys()), str) verify_collection_type("`tags_remove` keys", list(tags_remove.keys()), str) - verify_collection_type("`configs` values", list(configs.values()), (float, bool, int, str, datetime, list, set)) + verify_collection_type("`configs` values", list(configs.values()), (float, bool, int, str, datetime)) verify_collection_type("`metrics` values", list(metrics.values()), (float, int)) verify_collection_type("`tags_add` values", list(tags_add.values()), (list, set)) verify_collection_type("`tags_remove` values", list(tags_remove.values()), (list, set))