MySQL Pool connection closed - Sails

[MaheshkumarSundaram]

Hi @neonexus,

I just saw this issue pop up.

If I leave the Sails app running and come back after some hours (NOT SURE about any specific duration) during which the app remains idle, then when trying to do any API or backend related operations; sails-mysql adapter throws error stating that Pool is closed.

Haven't tested this with production build. I am doing that now.

Have you noticed anything like this before? Do you have any suggestions?
Thanks

[neonexus]

@MaheshkumarSundaram are you working with transactions, or dealing with connections directly? Generally this doesn’t happen, unless your database is configured to have less connections than what Sails is doing. Or if you have multiple instances all fighting for connections.

[MaheshkumarSundaram]

@neonexus,

Thank you. I'll try out your suggestions and get back to you. One more thing to note is I see this isssue in dev. I did a prod build and tried to replicate the issue, but I couldn't.

[neonexus]

@MaheshkumarSundaram any progress on this?

[MaheshkumarSundaram]

@neonexus,

Sorry, I forgot to update this. In my adaption, I have moved requestlog from DB to a file system as the logs generated are quite massive. So, I didn't get the issue anymore. I believe .exec() in requestlog might be the problem. Thank you.

[MaheshkumarSundaram]

@neonexus,

Following my previous comment, in the api/responses, as I don't use requestlog anymore,

Your Code:

module.exports = async function serverError(msg) {
    const req = this.req;
    const res = this.res;

    if (!msg) {
        msg = 'Unknown server error occurred';
    }

    const out = {
        success: false,
        errors: sails.helpers.simplifyErrors(msg),
        errorMessages: sails.helpers.getErrorMessages(msg),
    };

    res.status(500).json(out);

    await sails.helpers.finalizeRequestLog(req, res, out);
};

My use case:

module.exports = async function serverError(msg) {
    const req = this.req;
    const res = this.res;

    if (!msg) {
        msg = 'Unknown server error occurred';
    }

    const out = {
        success: false,
        errors: sails.helpers.simplifyErrors(msg),
        errorMessages: sails.helpers.getErrorMessages(msg),
    };

    res.status(500)

   return res.json(out); 
};

If I don't call finalizeRequestLog anymore, should there be a return for res.json(out) in all the responses?

Thanks

[neonexus]

Returns are optional, since you are calling res.json().