Type hierarchy actions missing or not handled correctly

[asmodeus812]

Problem: Currently you HAVE to first call the typeHierarchy action to load the contents, then call the class, sub or super type to change the direction, then open the java.action.showTypeHierarchy again, to be able to then see the hierarchy, that is somewhat counter intuitive, one would expect that all of those open the panel

The extension registers several types of type hierarchy such as class, super, sub types. However these are not exposed as actions, to be visible to the user.

Expected: I would like to be able to programatically directly show the super,sub or class type hierarchy of the type under the cursor.

The final goal is to be able to programatically do the following, to directly open the given hierarchy.

            if action == "showSuperTypes" then
                vim.fn.CocAction("runCommand", "java.action.showSupertypeHierarchy", ...)
                handled = true
            elseif action == "showSubTypes" then
                vim.fn.CocAction("runCommand", "java.action.showSubtypeHierarchy", ...)
                handled = true
            end

      context.subscriptions.push(commands.registerCommand(Commands.SHOW_CLASS_HIERARCHY, () => {
        typeHierarchyTree.changeDirection(TypeHierarchyDirection.both)
      }, null, true))

      context.subscriptions.push(commands.registerCommand(Commands.SHOW_SUPERTYPE_HIERARCHY, () => {
        typeHierarchyTree.changeDirection(TypeHierarchyDirection.parents)
      }, null, true))

      context.subscriptions.push(commands.registerCommand(Commands.SHOW_SUBTYPE_HIERARCHY, () => {
        typeHierarchyTree.changeDirection(TypeHierarchyDirection.children)
      }, null, true))

      {
        "command": "java.action.showClassHierarchy",
        "title": "Show Class Hierarchy",
        "icon": "$(type-hierarchy)",
        "enablement": "typeHierarchyDirection != both && typeHierarchySymbolKind != 10",
        "category": "Java"
      },
      {
        "command": "java.action.showSupertypeHierarchy",
        "title": "Show Supertype Hierarchy",
        "icon": "$(type-hierarchy-super)",
        "enablement": "typeHierarchyDirection != parents",
        "category": "Java"
      },
      {
        "command": "java.action.showSubtypeHierarchy",
        "title": "Show Subtype Hierarchy",
        "icon": "$(type-hierarchy-sub)",
        "enablement": "typeHierarchyDirection != children",
        "category": "Java"
      },

Related: neoclide/coc.nvim#5351 (comment)

[chemzqm]

You can use those commands like vim.fn.CocAction("runCommand", "java.action.showSupertypeHierarchy", ...)
they're internal like vscode-java which draw clickable icons for those commands.

[chemzqm]

directly show the super,sub or class type hierarchy of the type under the cursor.

You will need send request the server and display the results by CocRequest see :h CocRequest()

[asmodeus812]

You can use those commands like vim.fn.CocAction("runCommand", "java.action.showSupertypeHierarchy", ...) they're internal like vscode-java which draw clickable icons for those commands.

But that does not show the panel, that is part of my original report, you have to have called showTypeHierarchy first, that is the issue. Just calling showSupertypeHierarchy does not load the hierarchy nor does it show the panel...

So i belive the others should be made to work just as the SHOW_TYPE_HIERARCHY, which also loads the hierarchy and shows it. Note it calls setTypeHierarchy, unlike the others which just call a simple setter which only sets the direction, nothing else.

      context.subscriptions.push(commands.registerCommand(Commands.SHOW_TYPE_HIERARCHY, async (location?: any) => {
        let position = await window.getCursorPosition()
        if (location instanceof Uri) {
          typeHierarchyTree.setTypeHierarchy(Location.create(location.toString(), Range.create(position, position)), TypeHierarchyDirection.both)
        } else {
          if (window.activeTextEditor?.document.languageId !== "java") return
          typeHierarchyTree.setTypeHierarchy(Location.create(window.activeTextEditor.document.uri, Range.create(position, position)), TypeHierarchyDirection.both)
        }
      }))

      context.subscriptions.push(commands.registerCommand(Commands.SHOW_CLASS_HIERARCHY, () => {
        typeHierarchyTree.changeDirection(TypeHierarchyDirection.both)
      }, null, true))

      context.subscriptions.push(commands.registerCommand(Commands.SHOW_SUPERTYPE_HIERARCHY, () => {
        typeHierarchyTree.changeDirection(TypeHierarchyDirection.parents)
      }, null, true))

      context.subscriptions.push(commands.registerCommand(Commands.SHOW_SUBTYPE_HIERARCHY, () => {
        typeHierarchyTree.changeDirection(TypeHierarchyDirection.children)
      }, null, true))