Skip to content

Commit 3b7ded4

Browse files
authored
Fix Weaviate Retriever e2e tests (#257)
* Change embedding model * And now we can use the same pattern, since scores are the sames, like they are supposed to be * Also changing the image in the GitHub actions otherwise it doesn't work
1 parent c98f1ba commit 3b7ded4

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

.github/workflows/pr-e2e-tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- 'latest'
2121
services:
2222
t2v-transformers:
23-
image: cr.weaviate.io/semitechnologies/transformers-inference:sentence-transformers-all-MiniLM-L6-v2-onnx
23+
image: cr.weaviate.io/semitechnologies/transformers-inference:sentence-transformers-all-MiniLM-L6-v2
2424
env:
2525
ENABLE_CUDA: '0'
2626
weaviate:

.github/workflows/scheduled-e2e-tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- 'latest'
2020
services:
2121
t2v-transformers:
22-
image: cr.weaviate.io/semitechnologies/transformers-inference:sentence-transformers-all-MiniLM-L6-v2-onnx
22+
image: cr.weaviate.io/semitechnologies/transformers-inference:sentence-transformers-all-MiniLM-L6-v2
2323
env:
2424
ENABLE_CUDA: '0'
2525
credentials:

tests/e2e/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ services:
1010
- http
1111
image: cr.weaviate.io/semitechnologies/weaviate:1.25.1
1212
ports:
13-
- 8080:8080
14-
- 50051:50051
13+
- "8080:8080"
14+
- "50051:50051"
1515
restart: on-failure:0
1616
environment:
1717
TRANSFORMERS_INFERENCE_API: "http://t2v-transformers:8080"
@@ -22,7 +22,7 @@ services:
2222
ENABLE_MODULES: "text2vec-transformers"
2323
CLUSTER_HOSTNAME: "node1"
2424
t2v-transformers:
25-
image: cr.weaviate.io/semitechnologies/transformers-inference:sentence-transformers-all-MiniLM-L6-v2-onnx
25+
image: cr.weaviate.io/semitechnologies/transformers-inference:sentence-transformers-all-MiniLM-L6-v2
2626
environment:
2727
ENABLE_CUDA: "0"
2828
neo4j:

tests/e2e/weaviate_e2e/populate_dbs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def populate_dbs(
3131
collection_name,
3232
vectorizer_config=wvc.config.Configure.Vectorizer.text2vec_transformers(),
3333
vector_index_config=wvc.config.Configure.VectorIndex.hnsw(
34-
distance_metric=wvc.config.VectorDistances.COSINE # select prefered distance metric
34+
distance_metric=wvc.config.VectorDistances.COSINE # select preferred distance metric
3535
),
3636
properties=[
3737
wvc.config.Property(name="neo4j_id", data_type=wvc.config.DataType.TEXT),

tests/e2e/weaviate_e2e/test_weaviate_e2e.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,6 @@ def test_weaviate_neo4j_text_input_remote_embedder(
135135
r"labels=frozenset\({'Question'}\) properties={'question': 'In 1953 Watson \& "
136136
"Crick built a model of the molecular structure of this, the gene-carrying "
137137
"substance', 'id': 'question_c458c6f64d8d47429636bc5a94c97f51'}> "
138-
r"score=0.5[0-9]+>"
138+
r"score=0.6[0-9]+>"
139139
)
140140
assert re.match(pattern, results.items[0].content)

0 commit comments

Comments
 (0)