fix bug 4814, directed argument no longer necessary on operations as it's inferred by the Selection

Author: MacondoExpress

packages/graphql/src/translate/queryAST/ast/operations/ConnectionReadOperation.ts

@@ -40,7 +40,6 @@ export class ConnectionReadOperation extends Operation {
     public readonly relationship: RelationshipAdapter | undefined;
     public readonly target: ConcreteEntityAdapter;
 
-    protected directed: boolean;
     public nodeFields: Field[] = [];
     public edgeFields: Field[] = []; // TODO: merge with attachedTo?
     protected filters: Filter[] = [];
@@ -52,18 +51,15 @@ export class ConnectionReadOperation extends Operation {
 
     constructor({
         relationship,
-        directed,
         target,
         selection,
     }: {
         relationship: RelationshipAdapter | undefined;
         target: ConcreteEntityAdapter;
-        directed: boolean;
         selection: EntitySelection;
     }) {
         super();
         this.relationship = relationship;
-        this.directed = directed;
         this.target = target;
         this.selection = selection;
     }

packages/graphql/src/translate/queryAST/ast/operations/CypherOperation.ts

@@ -33,16 +33,14 @@ export class CypherOperation extends ReadOperation {
         cypherAttributeField,
         target,
         relationship,
-        directed,
         selection,
     }: {
         cypherAttributeField: AttributeAdapter;
         target: ConcreteEntityAdapter;
         relationship?: RelationshipAdapter;
-        directed?: boolean;
         selection: EntitySelection;
     }) {
-        super({ target, relationship, directed, selection });
+        super({ target, relationship, selection });
         this.cypherAttributeField = cypherAttributeField;
     }
 

packages/graphql/src/translate/queryAST/ast/operations/FulltextOperation.ts

@@ -40,19 +40,16 @@ export class FulltextOperation extends ReadOperation {
     constructor({
         target,
         relationship,
-        directed,
         scoreField,
         selection,
     }: {
         target: ConcreteEntityAdapter;
         relationship?: RelationshipAdapter;
-        directed?: boolean;
         scoreField: FulltextScoreField | undefined;
         selection: EntitySelection;
     }) {
         super({
             target,
-            directed,
             relationship,
             selection,
         });

packages/graphql/src/translate/queryAST/ast/operations/ReadOperation.ts

@@ -39,8 +39,6 @@ export class ReadOperation extends Operation {
     public readonly target: ConcreteEntityAdapter;
     public readonly relationship: RelationshipAdapter | undefined;
 
-    protected directed: boolean;
-
     public fields: Field[] = [];
     protected filters: Filter[] = [];
     protected authFilters: AuthorizationFilters[] = [];
@@ -53,17 +51,14 @@ export class ReadOperation extends Operation {
     constructor({
         target,
         relationship,
-        directed,
         selection,
     }: {
         target: ConcreteEntityAdapter;
         relationship?: RelationshipAdapter;
-        directed?: boolean;
         selection: EntitySelection;
     }) {
         super();
         this.target = target;
-        this.directed = directed ?? true;
         this.relationship = relationship;
 
         this.selection = selection;

packages/graphql/src/translate/queryAST/ast/selection/RelationshipSelection.ts

@@ -30,7 +30,7 @@ export class RelationshipSelection extends EntitySelection {
     // Overrides relationship target for composite entities
     private targetOverride: ConcreteEntityAdapter | undefined;
     private alias: string | undefined;
-    private directed: boolean;
+    private directed?: boolean;
     private optional: boolean;
 
     constructor({
@@ -49,7 +49,7 @@ export class RelationshipSelection extends EntitySelection {
         super();
         this.relationship = relationship;
         this.alias = alias;
-        this.directed = directed ?? true;
+        this.directed = directed;
         this.targetOverride = targetOverride;
         this.optional = optional ?? false;
     }

packages/graphql/src/translate/queryAST/factory/Operations/ConnectionFactory.ts

@@ -65,7 +65,7 @@ export class ConnectionFactory {
         resolveTree: ResolveTree;
         context: Neo4jGraphQLTranslationContext;
     }): CompositeConnectionReadOperation {
-        const directed = Boolean(resolveTree.args.directed) ?? true;
+        const directed = resolveTree.args.directed as boolean | undefined;
         const resolveTreeWhere: Record<string, any> = this.queryASTFactory.operationsFactory.getWhereArgs(resolveTree);
 
         let nodeWhere: Record<string, any>;
@@ -93,7 +93,6 @@ export class ConnectionFactory {
 
             const connectionPartial = new CompositeConnectionPartial({
                 relationship,
-                directed,
                 target: concreteEntity,
                 selection,
             });
@@ -140,7 +139,6 @@ export class ConnectionFactory {
                 context,
             });
         }
-        const directed = Boolean(resolveTree.args.directed) ?? true;
         const resolveTreeWhere: Record<string, any> = this.queryASTFactory.operationsFactory.getWhereArgs(resolveTree);
         checkEntityAuthentication({
             entity: target.entity,
@@ -152,14 +150,14 @@ export class ConnectionFactory {
         if (relationship) {
             selection = new RelationshipSelection({
                 relationship,
-                directed: Boolean(resolveTree.args?.directed ?? true),
+                directed: resolveTree.args.directed as boolean | undefined,
             });
         } else {
             selection = new NodeSelection({
                 target,
             });
         }
-        const operation = new ConnectionReadOperation({ relationship, directed, target, selection });
+        const operation = new ConnectionReadOperation({ relationship, target, selection });
 
         return this.hydrateConnectionOperationAST({
             relationship: relationship,

packages/graphql/src/translate/queryAST/factory/Operations/FulltextFactory.ts

@@ -94,7 +94,6 @@ export class FulltextFactory {
         });
         const operation = new FulltextOperation({
             target: entity,
-            directed: Boolean(resolverArgs.directed ?? true),
             scoreField,
             selection,
         });

packages/graphql/src/translate/queryAST/factory/Operations/ReadFactory.ts

@@ -87,7 +87,6 @@ export class ReadFactory {
             const operation = new ReadOperation({
                 target: entity,
                 relationship,
-                directed: Boolean(resolveTree.args?.directed ?? true),
                 selection,
             });
 
@@ -119,7 +118,6 @@ export class ReadFactory {
                 const readPartial = new CompositeReadPartial({
                     target: concreteEntity,
                     relationship,
-                    directed: Boolean(resolveTree.args?.directed ?? true),
                     selection,
                 });