Add simple relationship filters for interface and union relationships (#4829)

Author: a-alle

.changeset/grumpy-lamps-pump.md

@@ -0,0 +1,5 @@
+---
+"@neo4j/graphql": minor
+---
+
+Add simple relationship filter for relationships to interface types

packages/graphql/src/schema/generation/where-input.ts

@@ -163,13 +163,6 @@ export function withSourceWhereInputType({
     const relationshipTarget = relationshipAdapter.target;
     const relationshipSource = relationshipAdapter.source;
     const whereInput = composer.getITC(relationshipSource.operations.whereInputTypeName);
-    // TODO: relationship simple filters were not supported on Interface target, only connection filters
-    // when implementing translation, simply remove this if-case
-    if (relationshipTarget instanceof InterfaceEntityAdapter) {
-        const connectionFields = augmentWhereInputTypeWithConnectionFields(relationshipAdapter, deprecatedDirectives);
-        whereInput.addFields(connectionFields);
-        return whereInput;
-    }
     const fields = augmentWhereInputTypeWithRelationshipFields(relationshipAdapter, deprecatedDirectives);
     whereInput.addFields(fields);
 

packages/graphql/src/translate/queryAST/factory/FilterFactory.ts

@@ -221,24 +221,6 @@ export class FilterFactory {
         // this is because if isNull is true we want to wrap the Exist subclause in a NOT, but if isNull is true and isNot is true they negate each other
         const isNot = isNull ? !filterOps.isNot : filterOps.isNot;
 
-        if (isInterfaceEntity(relationship.target)) {
-            const relationshipFilter = this.createRelationshipFilterTreeNode({
-                relationship,
-                target: relationship.target,
-                isNot,
-                operator: filterOps.operator || "SOME",
-            });
-
-            if (!isNull) {
-                if (isInterfaceEntity(relationship.target)) {
-                    throw new Error("Interface filter to be implemented");
-                }
-                const targetNodeFilters = this.createNodeFilters(relationship.target, where);
-                relationshipFilter.addTargetNodeFilter(...targetNodeFilters);
-            }
-
-            return [relationshipFilter];
-        }
         const filteredEntities = getConcreteEntities(relationship.target, where);
         const relationshipFilters: RelationshipFilter[] = [];
         for (const concreteEntity of filteredEntities) {