Remove string allocation from Display impl for BoltType (#152)

knutwalker · web-flow · commit 6c9ba46f7dc5 · 2023-11-25T13:06:27.000+01:00
diff --git a/lib/src/types.rs b/lib/src/types.rs
@@ -68,11 +68,10 @@ pub enum BoltType {
 
 impl Display for BoltType {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        let value = match self {
-            BoltType::String(s) => s.to_string(),
-            _ => "to_string not implemented".to_owned(),
-        };
-        write!(f, "{}", value)
+        match self {
+            BoltType::String(s) => f.write_str(&s.value),
+            _ => f.write_str("to_string not implemented"),
+        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -68,11 +68,10 @@ pub enum BoltType {`
`68`	`68`
`69`	`69`	`impl Display for BoltType {`
`70`	`70`	`fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {`
`71`		`- let value = match self {`
`72`		`- BoltType::String(s) => s.to_string(),`
`73`		`- _ => "to_string not implemented".to_owned(),`
`74`		`- };`
`75`		`- write!(f, "{}", value)`
	`71`	`+ match self {`
	`72`	`+ BoltType::String(s) => f.write_str(&s.value),`
	`73`	`+ _ => f.write_str("to_string not implemented"),`
	`74`	`+ }`
`76`	`75`	`}`
`77`	`76`	`}`
`78`	`77`