nuke nullifier check from circuits

Author: olehmisar

packages/contracts/contracts/PoolERC20.sol

@@ -43,9 +43,8 @@ contract PoolERC20 is PoolGeneric {
     ) external {
         token.safeTransferFrom(msg.sender, address(this), amount);
 
-        PublicInputs.Type memory pi = PublicInputs.create(2 + 2 + U256_LIMBS);
+        PublicInputs.Type memory pi = PublicInputs.create(1 + 2 + U256_LIMBS);
         pi.push(getNoteHashTree().root);
-        pi.push(getNullifierTree().root);
         pi.push(address(token));
         pi.pushUint256Limbs(amount);
         // TODO(security): ensure noteHash does not already exist in the noteHashTree. If it exists, the tx will never be rolled up and the money will be lost.
@@ -107,10 +106,9 @@ contract PoolERC20 is PoolGeneric {
         NoteInput calldata joinNote
     ) external {
         PublicInputs.Type memory pi = PublicInputs.create(
-            2 + MAX_NOTES_TO_JOIN + 1
+            1 + MAX_NOTES_TO_JOIN + 1
         );
         pi.push(getNoteHashTree().root);
-        pi.push(getNullifierTree().root);
         pi.push(joinNote.noteHash);
         for (uint256 i = 0; i < MAX_NOTES_TO_JOIN; i++) {
             pi.push(nullifiers[i]);
@@ -137,9 +135,8 @@ contract PoolERC20 is PoolGeneric {
         NoteInput calldata changeNote,
         NoteInput calldata toNote
     ) external {
-        PublicInputs.Type memory pi = PublicInputs.create(5);
+        PublicInputs.Type memory pi = PublicInputs.create(4);
         pi.push(getNoteHashTree().root);
-        pi.push(getNullifierTree().root);
         pi.push(changeNote.noteHash);
         pi.push(toNote.noteHash);
         pi.push(nullifier);

packages/contracts/noir/common/src/lib.nr

@@ -97,5 +97,4 @@ impl std::ops::Sub for TokenAmount {
 
 pub struct TreeRoots {
     pub note_hash_root: Field,
-    pub nullifier_root: Field,
 }

packages/contracts/noir/common/src/owned_note.nr

@@ -38,13 +38,6 @@ where
             context.tree_roots().note_hash_root,
         );
         let nullifier = compute_nullifier_of_owned_note(self.note, secret_key);
-        // TODO(perf): optimize consume by checking nullifiers only during rollup
-        merkle_tree::assert_check_non_membership(
-            nullifier,
-            self.nullifier_low_leaf_preimage,
-            self.nullifier_low_leaf_membership_witness,
-            context.tree_roots().nullifier_root,
-        );
         context.push_nullifier(nullifier);
     }
 }

packages/contracts/noir/erc20_unshield/src/main.nr

@@ -12,6 +12,9 @@ fn main(
 ) -> pub common::Result<1, 1> {
     let mut context = common::Context::from(tree_roots);
 
+    // disabled because nullifiers are no longer checked on tx level
+    panic(f"not implemented");
+
     erc20::Token::burn(
         &mut context,
         from_secret_key,

packages/contracts/sdk/TreesService.ts

@@ -26,7 +26,6 @@ export class TreesService {
         note_hash_root: ethers.hexlify(
           noteHashTree.getRoot(INCLUDE_UNCOMMITTED),
         ),
-        nullifier_root: nullifierTree.getRoot(),
       };
     });