JIRA:RW-2412 check if gbqual on seqfeat is sorted before calling expensive sort

Jonathan Kans · gouriano · commit 3cde700fb383 · 2025-05-02T09:30:18.000-04:00
git-svn-id: https://anonsvn.ncbi.nlm.nih.gov/repos/v1/trunk/c++@104418 78c7ea69-d796-4a43-9a09-de51944f1b03
diff --git a/src/objtools/cleanup/newcleanupp.cpp b/src/objtools/cleanup/newcleanupp.cpp
@@ -6250,9 +6250,11 @@ void CNewCleanup_imp::x_CleanSeqFeatQuals(CSeq_feat& sf)
         GBQualBC(gbq);
     }
 
-    // sort/unique gbquals, just alphabetically
-    if (SortGBQuals(sf)) {
-        ChangeMade(CCleanupChange::eCleanQualifiers);
+    if (! GBQUAL_ON_SEQFEAT_IS_SORTED (sf, s_GbQualCompareLegalFirst)) {
+        // sort/unique gbquals, just alphabetically
+        if (SortGBQuals(sf)) {
+            ChangeMade(CCleanupChange::eCleanQualifiers);
+        }
     }
 
     if (!GBQUAL_ON_SEQFEAT_IS_UNIQUE(sf, s_GbQualEqual)) {

Original file line number	Diff line number	Diff line change
`@@ -6250,9 +6250,11 @@ void CNewCleanup_imp::x_CleanSeqFeatQuals(CSeq_feat& sf)`
`6250`	`6250`	`GBQualBC(gbq);`
`6251`	`6251`	`}`
`6252`	`6252`
`6253`		`- // sort/unique gbquals, just alphabetically`
`6254`		`- if (SortGBQuals(sf)) {`
`6255`		`- ChangeMade(CCleanupChange::eCleanQualifiers);`
	`6253`	`+ if (! GBQUAL_ON_SEQFEAT_IS_SORTED (sf, s_GbQualCompareLegalFirst)) {`
	`6254`	`+ // sort/unique gbquals, just alphabetically`
	`6255`	`+ if (SortGBQuals(sf)) {`
	`6256`	`+ ChangeMade(CCleanupChange::eCleanQualifiers);`
	`6257`	`+ }`
`6256`	`6258`	`}`
`6257`	`6259`
`6258`	`6260`	`if (!GBQUAL_ON_SEQFEAT_IS_UNIQUE(sf, s_GbQualEqual)) {`