From 24deaf733c1ca5c367abe09916420fe160dbcb7c Mon Sep 17 00:00:00 2001 From: Tanner Doshier Date: Fri, 30 May 2025 11:33:08 -0400 Subject: [PATCH] Better specify expected Node.js version --- .github/workflows/cd-app-storybook.yml | 2 +- .github/workflows/ci-app.yml | 14 +++++++------- app/Dockerfile | 2 +- app/package-lock.json | 2 +- app/package.json | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/cd-app-storybook.yml b/.github/workflows/cd-app-storybook.yml index 74f36ba9..26cad1bf 100644 --- a/.github/workflows/cd-app-storybook.yml +++ b/.github/workflows/cd-app-storybook.yml @@ -29,7 +29,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v4 with: - node-version: 20 + node-version-file: ./app/package.json cache-dependency-path: ./app/package-lock.json # or yarn.lock cache: npm # or yarn - name: Setup Pages diff --git a/.github/workflows/ci-app.yml b/.github/workflows/ci-app.yml index b3dbf643..477607fe 100644 --- a/.github/workflows/ci-app.yml +++ b/.github/workflows/ci-app.yml @@ -14,7 +14,7 @@ defaults: working-directory: ./app env: - NODE_VERSION: 20 + NODE_VERSION_FILE: ./app/package.json LOCKFILE_PATH: ./app/package-lock.json # or yarn.lock PACKAGE_MANAGER: npm # or yarn @@ -31,7 +31,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: ${{ env.NODE_VERSION }} + node-version-file: ${{ env.NODE_VERSION_FILE }} cache-dependency-path: ${{ env.LOCKFILE_PATH }} cache: ${{ env.PACKAGE_MANAGER }} - run: npm ci @@ -52,7 +52,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: ${{ env.NODE_VERSION }} + node-version-file: ${{ env.NODE_VERSION_FILE }} cache-dependency-path: ${{ env.LOCKFILE_PATH }} cache: ${{ env.PACKAGE_MANAGER }} - run: npm ci @@ -66,7 +66,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: ${{ env.NODE_VERSION }} + node-version-file: ${{ env.NODE_VERSION_FILE }} cache-dependency-path: ${{ env.LOCKFILE_PATH }} cache: ${{ env.PACKAGE_MANAGER }} - run: npm ci @@ -80,7 +80,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: ${{ env.NODE_VERSION }} + node-version-file: ${{ env.NODE_VERSION_FILE }} cache-dependency-path: ${{ env.LOCKFILE_PATH }} cache: ${{ env.PACKAGE_MANAGER }} - run: npm ci @@ -95,7 +95,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: ${{ env.NODE_VERSION }} + node-version-file: ${{ env.NODE_VERSION_FILE }} cache-dependency-path: ${{ env.LOCKFILE_PATH }} cache: ${{ env.PACKAGE_MANAGER }} @@ -123,7 +123,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: ${{ env.NODE_VERSION }} + node-version-file: ${{ env.NODE_VERSION_FILE }} cache-dependency-path: ${{ env.LOCKFILE_PATH }} cache: ${{ env.PACKAGE_MANAGER }} - run: npm ci diff --git a/app/Dockerfile b/app/Dockerfile index 568ec67b..396e9f3f 100644 --- a/app/Dockerfile +++ b/app/Dockerfile @@ -1,7 +1,7 @@ # This file is largely based on the template-application-flask Dockerfile and # Next.js Docker example: https://github.com/vercel/next.js/blob/canary/examples/with-docker-compose # ============================================================================= -FROM node:20.18.1-bullseye-slim AS base +FROM node:20.19.2-bullseye-slim AS base WORKDIR /app # Install dependencies diff --git a/app/package-lock.json b/app/package-lock.json index a1b8f506..2a0a7be1 100644 --- a/app/package-lock.json +++ b/app/package-lock.json @@ -58,7 +58,7 @@ "typescript": "^5.0.0" }, "engines": { - "node": ">=20.0.0", + "node": "20.19.2", "npm": ">=10.0.0" } }, diff --git a/app/package.json b/app/package.json index 3e66749c..8cd36405 100644 --- a/app/package.json +++ b/app/package.json @@ -3,7 +3,7 @@ "version": "0.1.0", "private": true, "engines": { - "node": ">=20.0.0", + "node": "20.19.2", "npm": ">=10.0.0" }, "scripts": {