Merging userPage and vaultPage

[5e-Cleric]

It has forever been suggested the merge of the userpage into the vaultpage, since both pages request data based on a query and display it in a similar manner.

Discussion on gitter has produced a few keypoints:

• Since userpage needs to search the user google's account for unstubbed brews, vaultpage would have to do that as well, this is unpractical, and a decision has been made to try to fix that before, by running a script to update such brews. Add Google service account to file permissions #4352 has been raised durinng that discussion to take care of google permission issues required for this, and that should help make the google files premissions be more precise, more info in that PR

• Since listPage contains a navbar with filters for the files, that will have to be remade. from here on out, all those filters will be built into the query, as they are in vaultPage.

• Pagination on the server side will be implemented for the userpage, to better match with vaultPage

There also has been talk about adding more filters such as renderers, or tags

Anoter important point, searching by tags must be done or lost in userpage.

[dbolack-ab]

Last I spotted in the conversation, there were options for which method to handle the stubless Google Brews

• Have Vault pick up the discovery of unstubbed Brews
• Move discovery of Unstubbed Brews to a User Page function, requiring interactivity
• Run a one-time batch job that does discovery across the NaturalCrit login base
• Abandon stub discovery

While 3 seems like the best, most obvious choice, it still requires an interactive user login to update the permissions on the Homebrewery folder for discovery to happen, as I understand the current permissions assignment. If so, we either need to run this as an infrequent batch job or select another option.

[5e-Cleric]

To be completely honest, 4 seems like the best option in my opinion.

If a brew that old has not been stubbed yet, it very likely does not matter anymore.

[Gazook89]

If a brew that old has not been stubbed yet, it very likely does not matter anymore.

I don't think that's right. We've made steps to move from "tool" towards "platform", and as such the reliability in terms of storing and finding brews is likely more important than it has been. The users did nothing wrong, so we should do what we can to make those brews just as discoverable as the rest. Especially since we have the other options.

[5e-Cleric]

yeah, after making that comment i asked calc, and yeah there are lots of brews like that, approach 3 is better

[calculuschild]

Script is built and works. ~5,000 / 43,999 users have been processed. At least some portion have revoked their credentials and so we cannot process them, but this would specifically be users who have chosen to block the app, or possibly that they haven't used the app for a while, if I'm remembering these expire right around one year. I will show the statistics when this is done. We may decide to still implement one of the other options depending how those numbers turn out.