Optimise dependencies based on framework #848
Assignees
Labels
Comments
|
thanks for the report @thompson-tomo. what's your target framework? e.g. I believe we had to include STJ because of a CVE |
|
Most of the time I target net 8 due to it being LTS. You are correct 8.0.4 & 6.0.9 of STJ has a CVE. The advantage of leveraging the framework for STJ is that CVE can be addressed by updating the installed framework on the end user machine or sdk on build machine. No need for new library release. |
|
makes sense. I think we had to include at the time because github bot kept shouting probably because the fix wasn't included in the sdks at that point. |
thompson-tomo
added a commit
to thompson-tomo/nats.net
that referenced
this issue
May 12, 2025
Merged
thompson-tomo
added a commit
to thompson-tomo/nats.net
that referenced
this issue
May 25, 2025
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
thompson-tomo
added a commit
to thompson-tomo/nats.net
that referenced
this issue
May 25, 2025
Signed-off-by: James Thompson <thompson.tomo@outlook.com>
mtmk
pushed a commit
that referenced
this issue
May 29, 2025
* #848 Tweak dependencies Signed-off-by: James Thompson <thompson.tomo@outlook.com> * Update NATS.Client.Core.csproj Signed-off-by: James Thompson <thompson.tomo@outlook.com> * Update NATS.Client.Core.csproj Signed-off-by: James Thompson <thompson.tomo@outlook.com> * Make STJ explicit dependency for JetStream Signed-off-by: James Thompson <thompson.tomo@outlook.com> * Update NATS.Client.JetStream.csproj Signed-off-by: James Thompson <thompson.tomo@outlook.com> * Force sdk to 8.0.0 Signed-off-by: James Thompson <thompson.tomo@outlook.com> * Add newer stj for net 6 Signed-off-by: James Thompson <thompson.tomo@outlook.com> --------- Signed-off-by: James Thompson <thompson.tomo@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Proposed change
Remove dependencies which can be provided by the framework natively ie System.Text.Json & System.io.pipelines which are dependencies on the core package
Use case
I want to minimise dependencies in my project by utilising framework dependencies wherever possible
Contribution
No response
The text was updated successfully, but these errors were encountered: