Skip to content

Revisit the hacky requirements.txt approach in ci.yml #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanjmcdougall opened this issue Feb 3, 2025 · 5 comments · Fixed by #334
Open

Revisit the hacky requirements.txt approach in ci.yml #252

nathanjmcdougall opened this issue Feb 3, 2025 · 5 comments · Fixed by #334
Assignees
Labels
enhancement New feature or request

Comments

@nathanjmcdougall
Copy link
Owner

I think uv may have matured since this hack was imagined, rendering it unnecessary:

- name: Setup dependencies
run: |
uv export --resolution ${{ matrix.resolution }} > requirements.txt
uv pip install --system --break-system-packages -r requirements.txt

@nathanjmcdougall nathanjmcdougall added the enhancement New feature or request label Feb 3, 2025
@nathanjmcdougall nathanjmcdougall self-assigned this Feb 3, 2025
@nathanjmcdougall
Copy link
Owner Author

Similar idea here:

www.github.com/python-attrs/attrs/pull/1409/files

nathanjmcdougall added a commit that referenced this issue Feb 24, 2025
@nathanjmcdougall
Copy link
Owner Author

@nathanjmcdougall nathanjmcdougall added the blocked Another issue is preventing progress label Feb 24, 2025
@nathanjmcdougall nathanjmcdougall added this to the v0.8.0 milestone Feb 25, 2025
@nathanjmcdougall
Copy link
Owner Author

Waiting for a new release here:
https://github.com/CodSpeedHQ/valgrind-codspeed/releases

@nathanjmcdougall
Copy link
Owner Author

It looks like despite the new release it's still not resolved. So still waiting on astral-sh/python-build-standalone#508

@nathanjmcdougall
Copy link
Owner Author

Unfortunately, #334 needs to be reverted because it's breaking codecov. We need to try again but make sure codecov is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant