Feature/84 bug pt rule added even when pytest is not used (#87)

* Fix bug where ruff rules for all tools get added

* Fix bug where all ruff rules are always enabled even for unused tools

Author: nathanjmcdougall

src/usethis/_interface/tool.py

@@ -101,8 +101,9 @@ def _ruff(*, remove: bool = False, offline: bool = False) -> None:
 
     rules = []
     for _tool in ALL_TOOLS:
-        with contextlib.suppress(NotImplementedError):
-            rules += _tool.get_associated_ruff_rules()
+        if _tool.is_used() or _tool.name == "ruff":
+            with contextlib.suppress(NotImplementedError):
+                rules += _tool.get_associated_ruff_rules()
 
     if not remove:
         add_deps_to_group(tool.dev_deps, "dev", offline=offline)

tests/usethis/_integrations/bitbucket/test_cache.py

@@ -1,6 +1,13 @@
 from pathlib import Path
 
-from usethis._integrations.bitbucket.cache import Cache, add_cache, get_caches
+import pytest
+
+from usethis._integrations.bitbucket.cache import (
+    Cache,
+    CacheAlreadyExistsError,
+    add_cache,
+    get_caches,
+)
 from usethis._utils._test import change_cwd
 
 
@@ -15,3 +22,14 @@ def test_in_caches(self, uv_init_dir: Path):
             # Assert
             caches = get_caches()
         assert caches == [cache]
+
+    def test_already_exists(self, uv_init_dir: Path):
+        # Arrange
+        cache = Cache(name="example", path="~/.cache/example")
+
+        with change_cwd(uv_init_dir):
+            add_cache(cache)
+
+            # Act, Assert
+            with pytest.raises(CacheAlreadyExistsError):
+                add_cache(cache, exists_ok=False)

tests/usethis/_interface/test_ci.py

@@ -105,25 +105,28 @@ def test_not_mentioned_if_not_used(self, uv_init_dir: Path):
                 assert "pytest" not in contents
 
     class TestRemove:
-        def test_config_file_gone(self, uv_init_dir: Path):
-            # Arrange
-            (uv_init_dir / "bitbucket-pipelines.yml").touch()
+        class TestPyproject:
+            def test_removed(self, uv_init_dir: Path):
+                # Arrange
+                (uv_init_dir / "bitbucket-pipelines.yml").touch()
 
-            # Act
-            with change_cwd(uv_init_dir):
-                _bitbucket(remove=True, offline=is_offline())
+                # Act
+                with change_cwd(uv_init_dir):
+                    _bitbucket(remove=True, offline=is_offline())
 
-            # Assert
-            assert not (uv_init_dir / "bitbucket-pipelines.yml").exists()
+                # Assert
+                assert not (uv_init_dir / "bitbucket-pipelines.yml").exists()
 
-        def test_message(self, uv_init_dir: Path, capfd: pytest.CaptureFixture[str]):
-            # Arrange
-            (uv_init_dir / "bitbucket-pipelines.yml").touch()
+            def test_message(
+                self, uv_init_dir: Path, capfd: pytest.CaptureFixture[str]
+            ):
+                # Arrange
+                (uv_init_dir / "bitbucket-pipelines.yml").touch()
 
-            # Act
-            with change_cwd(uv_init_dir):
-                _bitbucket(remove=True, offline=is_offline())
+                # Act
+                with change_cwd(uv_init_dir):
+                    _bitbucket(remove=True, offline=is_offline())
 
-            # Assert
-            out, _ = capfd.readouterr()
-            assert out == "✔ Removing 'bitbucket-pipelines.yml' file.\n"
+                # Assert
+                out, _ = capfd.readouterr()
+                assert out == "✔ Removing 'bitbucket-pipelines.yml' file.\n"

tests/usethis/_interface/test_tool.py

@@ -362,7 +362,7 @@ def test_stdout(self, uv_init_dir: Path, capfd: pytest.CaptureFixture[str]):
             assert out == (
                 "✔ Adding 'ruff' to the 'dev' dependency group.\n"
                 "✔ Adding ruff config to 'pyproject.toml'.\n"
-                "✔ Enabling ruff rules 'C4', 'E4', 'E7', 'E9', 'F', 'FURB', 'I', 'PLE', 'PLR', \n'PT', 'RUF', 'SIM', 'UP' in 'pyproject.toml'.\n"
+                "✔ Enabling ruff rules 'C4', 'E4', 'E7', 'E9', 'F', 'FURB', 'I', 'PLE', 'PLR', \n'RUF', 'SIM', 'UP' in 'pyproject.toml'.\n"
                 "☐ Call the 'ruff check --fix' command to run the ruff linter with autofixes.\n"
                 "☐ Call the 'ruff format' command to run the ruff formatter.\n"
             )
@@ -442,13 +442,106 @@ def test_roundtrip(self, uv_init_dir: Path):
 
 
 class TestPytest:
-    def test_dep(self, uv_init_dir: Path):
-        with change_cwd(uv_init_dir):
-            _pytest(offline=is_offline())
-
-            assert {
-                "pytest",
-                "pytest-md",
-                "pytest-cov",
-                "coverage",
-            } <= set(get_deps_from_group("test"))
+    class TestAdd:
+        def test_dep(self, uv_init_dir: Path):
+            with change_cwd(uv_init_dir):
+                _pytest(offline=is_offline())
+
+                assert {
+                    "pytest",
+                    "pytest-md",
+                    "pytest-cov",
+                    "coverage",
+                } <= set(get_deps_from_group("test"))
+
+    class TestRemove:
+        class TestRuffIntegration:
+            def test_deselected(self, uv_init_dir: Path):
+                # Arrange
+                (uv_init_dir / "pyproject.toml").write_text(
+                    """\
+[tool.ruff.lint]
+select = ["E", "PT"]
+"""
+                )
+
+                # Act
+                with change_cwd(uv_init_dir):
+                    _pytest(remove=True, offline=is_offline())
+
+                # Assert
+                assert (uv_init_dir / "pyproject.toml").read_text() == (
+                    """\
+[tool.ruff.lint]
+select = ["E"]
+"""
+                )
+
+            def test_message(
+                self, uv_init_dir: Path, capfd: pytest.CaptureFixture[str]
+            ):
+                # Arrange
+                (uv_init_dir / "pyproject.toml").write_text(
+                    """\
+[tool.ruff.lint]
+select = ["PT"]
+"""
+                )
+
+                # Act
+                with change_cwd(uv_init_dir):
+                    _pytest(remove=True, offline=is_offline())
+
+                # Assert
+                out, _ = capfd.readouterr()
+                assert out == ("✔ Disabling ruff rule 'PT' in 'pyproject.toml'.\n")
+
+        class TestPyproject:
+            def test_removed(self, uv_init_dir: Path):
+                # Arrange
+                (uv_init_dir / "pyproject.toml").write_text(
+                    """\
+    [tool.pytest]
+    foo = "bar"
+    """
+                )
+
+                # Act
+                with change_cwd(uv_init_dir):
+                    _pytest(remove=True, offline=is_offline())
+
+                # Assert
+                assert (uv_init_dir / "pyproject.toml").read_text() == ""
+
+            def test_message(
+                self, uv_init_dir: Path, capfd: pytest.CaptureFixture[str]
+            ):
+                # Arrange
+                (uv_init_dir / "pyproject.toml").write_text(
+                    """\
+    [tool.pytest]
+    foo = "bar"
+    """
+                )
+
+                # Act
+                with change_cwd(uv_init_dir):
+                    _pytest(remove=True, offline=is_offline())
+
+                # Assert
+                out, _ = capfd.readouterr()
+                # N.B. we don't put `pytest` in quotes because we are referring to the
+                # tool, not the package.
+                assert out == "✔ Removing pytest config from 'pyproject.toml'.\n"
+
+        class Dependencies:
+            def test_removed(self, uv_init_dir: Path):
+                # Arrange
+                add_deps_to_group(["pytest"], "test", offline=is_offline())
+
+                # Act
+                with change_cwd(uv_init_dir):
+                    _pytest(remove=True, offline=is_offline())
+
+                # Assert
+                assert not get_deps_from_group("test")