Skip to content

Commit 150ebe4

Browse files
committed
refactor: return a spanned string from typeName
1 parent 8e6e6f8 commit 150ebe4

File tree

2 files changed

+12
-13
lines changed

2 files changed

+12
-13
lines changed

src/tests.zig

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -307,16 +307,16 @@ test "typenames" {
307307
var lua = try Lua.init(testing.allocator);
308308
defer lua.deinit();
309309

310-
try expectEqualStringsSentinel("no value", lua.typeName(.none));
311-
try expectEqualStringsSentinel("nil", lua.typeName(.nil));
312-
try expectEqualStringsSentinel("boolean", lua.typeName(.boolean));
313-
try expectEqualStringsSentinel("userdata", lua.typeName(.light_userdata));
314-
try expectEqualStringsSentinel("number", lua.typeName(.number));
315-
try expectEqualStringsSentinel("string", lua.typeName(.string));
316-
try expectEqualStringsSentinel("table", lua.typeName(.table));
317-
try expectEqualStringsSentinel("function", lua.typeName(.function));
318-
try expectEqualStringsSentinel("userdata", lua.typeName(.userdata));
319-
try expectEqualStringsSentinel("thread", lua.typeName(.thread));
310+
try expectEqualStrings("no value", lua.typeName(.none));
311+
try expectEqualStrings("nil", lua.typeName(.nil));
312+
try expectEqualStrings("boolean", lua.typeName(.boolean));
313+
try expectEqualStrings("userdata", lua.typeName(.light_userdata));
314+
try expectEqualStrings("number", lua.typeName(.number));
315+
try expectEqualStrings("string", lua.typeName(.string));
316+
try expectEqualStrings("table", lua.typeName(.table));
317+
try expectEqualStrings("function", lua.typeName(.function));
318+
try expectEqualStrings("userdata", lua.typeName(.userdata));
319+
try expectEqualStrings("thread", lua.typeName(.thread));
320320
}
321321

322322
test "executing string contents" {

src/ziglua.zig

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,9 +1095,8 @@ pub const Lua = struct {
10951095
}
10961096

10971097
/// Returns the name of the given `LuaType` as a null-terminated slice
1098-
/// TODO: return a spanned string
1099-
pub fn typeName(lua: *Lua, t: LuaType) [*:0]const u8 {
1100-
return c.lua_typename(lua.state, @enumToInt(t));
1098+
pub fn typeName(lua: *Lua, t: LuaType) [:0]const u8 {
1099+
return std.mem.span(c.lua_typename(lua.state, @enumToInt(t)));
11011100
}
11021101

11031102
/// Returns the pseudo-index that represents the `i`th upvalue of the running function

0 commit comments

Comments
 (0)