Skip to content

Commit 950ec1d

Browse files
committed
fix(slice): calculate classified name once for namespaced slice
1 parent 68a99c2 commit 950ec1d

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

packages/ngrx-slice/.release-it.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
}
2929
},
3030
"@release-it/bumper": {
31-
"in": "packages/ngrx-slice/package.json",
32-
"out": ["packages/ngrx-slice/package.json", "dist/packages/ngrx-slice/package.json"]
31+
"in": "packages/ngrx-slice/version.json",
32+
"out": "dist/packages/ngrx-slice/package.json"
3333
}
3434
},
3535
"git": {

packages/ngrx-slice/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngrx-slice",
3-
"version": "6.2.1",
3+
"version": "0.0.0",
44
"license": "MIT",
55
"description": "createSlice plugin for NgRX",
66
"keywords": [

packages/ngrx-slice/src/lib/create-slice.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,14 @@ export function createNamespacedSlice<
105105
sliceActionNameGetter,
106106
});
107107

108+
const classifiedName = classify(name);
109+
108110
return {
109-
[`${classify(name)}Feature`]: {
111+
[`${classifiedName}Feature`]: {
110112
name: sliceName,
111113
reducer,
112114
},
113-
[`${classify(name)}Actions`]: actions,
114-
[`${classify(name)}Selectors`]: selectors,
115+
[`${classifiedName}Actions`]: actions,
116+
[`${classifiedName}Selectors`]: selectors,
115117
} as NamespacedSlice<SliceState, SliceName, CaseReducers>;
116118
}

packages/ngrx-slice/version.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"version": "6.2.1"
3+
}

0 commit comments

Comments
 (0)