Skip to content

Commit 01c6687

Browse files
author
Chau Tran
committed
feat(slice): remove ngrx immer dependency
1 parent 3405b98 commit 01c6687

File tree

4 files changed

+8
-21
lines changed

4 files changed

+8
-21
lines changed

packages/ngrx-slice/README.md

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,14 @@ yarn add ngrx-slice
1616

1717
### Peer Dependencies
1818

19-
`ngrx-slice` has `ngrx-immer` and `immer` as its `peerDependencies` so go ahead and install those:
19+
`ngrx-slice` has `immer` as its `peerDependencies` so go ahead and install it:
2020

2121
```shell
22-
npm install ngrx-immer immer
22+
npm install immer
2323
```
2424

2525
```shell
26-
yarn add ngrx-immer immer
27-
```
28-
29-
Here's one command for all three:
30-
31-
```shell
32-
npm install ngrx-slice ngrx-immer immer
33-
```
34-
35-
```shell
36-
yarn add ngrx-slice ngrx-immer immer
26+
yarn add immer
3727
```
3828

3929
## Documentations

packages/ngrx-slice/src/lib/create-slice-reducer.spec.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ const initialState = {
66
foo: 1,
77
};
88

9-
const getter = (featureName: string, actionName: string) =>
10-
`${featureName}/${actionName}`;
119

1210
const actions = {
1311
increment: createAction('foo/increment'),
@@ -22,7 +20,6 @@ describe(createSliceReducer.name, () => {
2220
beforeEach(() => {
2321
reducer = createSliceReducer(
2422
initialState,
25-
getter,
2623
actions as any,
2724
{
2825
increment: (state) => {
@@ -33,7 +30,7 @@ describe(createSliceReducer.name, () => {
3330
},
3431
},
3532
[
36-
on<typeof initialState, [typeof double]>(double, (state) => ({
33+
on(double, (state) => ({
3734
...state,
3835
foo: state.foo * 2,
3936
})),

packages/ngrx-slice/src/lib/create-slice-reducer.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export function createSliceReducer<
1515
CaseReducers extends SliceCaseReducers<SliceState> = SliceCaseReducers<SliceState>
1616
>(
1717
initialState: SliceState,
18-
sliceActionNameGetter: SliceActionNameGetter,
1918
actions: SliceActions<SliceState, CaseReducers>,
2019
reducers: CaseReducers,
2120
extraReducers?: SliceOptions<

packages/ngrx-slice/src/lib/create-slice.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { createFeatureSelector } from '@ngrx/store';
1+
import {createFeatureSelector, ActionCreator} from '@ngrx/store';
22
import type { Draft } from 'immer';
33
import { createSliceActions } from './create-slice-actions';
44
import { createSliceReducer } from './create-slice-reducer';
@@ -57,12 +57,11 @@ export function createSlice<
5757
name,
5858
sliceActionNameGetter,
5959
reducers,
60-
reducersToActions,
60+
reducersToActions
6161
);
6262

6363
const reducer = createSliceReducer<SliceState, SliceName, CaseReducers>(
6464
initialState,
65-
sliceActionNameGetter,
6665
actions,
6766
reducers,
6867
extraReducers
@@ -88,6 +87,7 @@ export function createNamespacedSlice<
8887
initialState,
8988
reducers,
9089
extraReducers,
90+
reducersToActions,
9191
sliceActionNameGetter = defaultSliceActionNameGetter,
9292
}: SliceOptions<SliceName, SliceState, CaseReducers>): NamespacedSlice<
9393
SliceState,
@@ -104,6 +104,7 @@ export function createNamespacedSlice<
104104
initialState,
105105
reducers,
106106
extraReducers,
107+
reducersToActions,
107108
sliceActionNameGetter,
108109
});
109110

0 commit comments

Comments
 (0)