NFProjectSystem.CSharp.targets import failed in SDK Style project

[wherewhere]

Tool

Visual Studio extension

Description

I am trying to target netnano1.0 in SDK Style project. It works fine when I import NFProjectSystem.CSharp.targets in .nfproj. But when I try to move it to Directory.Build.targets, it failed with

Because the NFProjectSystem.CSharp.targets has imports the Microsoft.CSharp.CurrentVersion.targets and the SDK imports it again.

It also warning when import it in .nfproj.
warning MSB4011: 无法再次导入“C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.Common.targets”。可能已在“C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\amd64\Microsoft.CSharp.CurrentVersion.targets (348,5)”处导入过它。这很可能是生成创作错误。将忽略此后续导入。[C:\Users\qq251\Downloads\GitHub\new\NFApp1\NFApp1\NFApp1.nfproj]

#1067

How to reproduce

Directory.Build.props

<Project>
  
  <PropertyGroup Condition="$(MSBuildProjectExtension) == '.nfproj'">
    <AssetTargetFallback>$(AssetTargetFallback);net</AssetTargetFallback>
    <NoWarn>$(NoWarn);NU1701</NoWarn>
    <NanoFrameworkProjectSystemPath Condition="$(NanoFrameworkProjectSystemPath) == ''">$(MSBuildExtensionsPath)\nanoFramework\v1.0\</NanoFrameworkProjectSystemPath>
  </PropertyGroup>
  
  <Import Project="$(NanoFrameworkProjectSystemPath)NFProjectSystem.Default.props" Condition="$(MSBuildProjectExtension) == '.nfproj' and Exists('$(NanoFrameworkProjectSystemPath)NFProjectSystem.Default.props')" />
  <Import Project="$(NanoFrameworkProjectSystemPath)NFProjectSystem.props" Condition="$(MSBuildProjectExtension) == '.nfproj' and Exists('$(NanoFrameworkProjectSystemPath)NFProjectSystem.props')" />

</Project>

Directory.Build.targets

<Project>

  <ItemGroup>
    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all">
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
  </ItemGroup>
  
  <ItemGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'netnano'))">
    <PackageReference Include="nanoFramework.CoreLibrary.NoReflection" Version="1.17.12" />
  </ItemGroup>
  
</Project>

.nfproj

<Project Sdk="Microsoft.NET.Sdk">
  
  <PropertyGroup>
    <LangVersion>latest</LangVersion>
    <OutputType>Exe</OutputType>
    <TargetFramework>netnano1.0</TargetFramework>
  </PropertyGroup>
  
  <Import Project="$(NanoFrameworkProjectSystemPath)NFProjectSystem.CSharp.targets" Condition="Exists('$(NanoFrameworkProjectSystemPath)NFProjectSystem.CSharp.targets')" />

</Project>

Project:
NFApp1.zip

Expected behaviour

No response

Screenshots

No response

Aditional context

No response

[josesimoes]

nanoFramework project system uses the old style C# project system, that's why you see all these issues when trying to use in SDK style project.

[wherewhere]

But it is too old that still using package.confg to restore nuget, and the nuget package does not target netnano so that I have to fallback to net to restore it...

[josesimoes]

I would like very much to move to the SDK style, just that's not possible right now because of the debugger.
Hopefully that will be possible in the next VS version.

In the meantime, you have to use what is available. dotnet CLI is not doable. Therefore, you have to use VS package manager and nuget CLI, which been working for everyone else working with nanoFramework.