Skip to content

Commit 2f7f7ac

Browse files
committed
Review feedback, remove fixme comment.
1 parent 7f0c8f6 commit 2f7f7ac

File tree

1 file changed

+0
-17
lines changed
  • src/librustc_mir/build/matches

1 file changed

+0
-17
lines changed

src/librustc_mir/build/matches/mod.rs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -131,23 +131,6 @@ impl<'a, 'gcx, 'tcx> Builder<'a, 'gcx, 'tcx> {
131131
// This should ensure that you cannot change
132132
// the variant for an enum while you are in
133133
// the midst of matching on it.
134-
//
135-
// FIXME: I originally had put this at the
136-
// start of each elem of arm_blocks (see
137-
// ArmBlocks construction above). But this was
138-
// broken; for example, when you had a trivial
139-
// match like `match "foo".to_string() { _s =>
140-
// {} }`, it would inject a ReadForMatch
141-
// *after* the move of the input into `_s`,
142-
// and that then does not pass the borrow
143-
// check.
144-
//
145-
// * So: I need to fine tune exactly *where*
146-
// the ReadForMatch belongs. Should it come
147-
// at the beginning of each pattern match,
148-
// or the end? And, should there be one
149-
// ReadForMatch per arm, or one per
150-
// candidate (aka pattern)?
151134

152135
self.cfg.push(*pre_binding_block, Statement {
153136
source_info,

0 commit comments

Comments
 (0)