Skip to content

Commit 5d4ac52

Browse files
authored
fix(iroh-cli): Fix printing of doctor connect/accept output (#2166)
## Description Apparently now metrics work and are attempted to be printed. Unfortunately they also print a tracing error message to stderr, the stderr which is also being used by the progress bar. The result is that the progress bar ends up with an extra newline and the first line of it is not being repainted but flows up, resulting in lots of garbage in the terminal history. By removing the log message the output is perserved much better. ## Notes & open questions It could be argued that this is not a good fix, if the loglevel is changed to info or debug the same problems would occur. However we already have the ability to log to a random filedescriptor and will soon be able to log to files. So maybe that's just fine for now. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates if relevant.~~ - ~~[ ] Tests if relevant.~~
1 parent ceaf168 commit 5d4ac52

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

iroh-cli/src/commands/doctor.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,6 @@ impl Gui {
400400
fn update_counters(target: &ProgressBar) {
401401
if let Some(core) = Core::get() {
402402
let metrics = core.get_collector::<MagicsockMetrics>().unwrap();
403-
tracing::error!("metrics enabled");
404403
let send_ipv4 = HumanBytes(metrics.send_ipv4.get());
405404
let send_ipv6 = HumanBytes(metrics.send_ipv6.get());
406405
let send_relay = HumanBytes(metrics.send_relay.get());

0 commit comments

Comments
 (0)