fix(iroh): shutdown sync engine on iroh node shutdown (#2131)

- make sure the sync engine is shutdown in time
- enable `fs-store` by default

Author: dignifiedquire

iroh/Cargo.toml

@@ -57,7 +57,7 @@ clap = { version = "4", features = ["derive"], optional = true }
 indicatif = { version = "0.17", features = ["tokio"], optional = true }
 
 [features]
-default = ["metrics"]
+default = ["metrics", "fs-store"]
 metrics = ["iroh-metrics", "iroh-bytes/metrics"]
 fs-store = ["iroh-bytes/fs-store"]
 test = []

iroh/src/node.rs

@@ -277,7 +277,7 @@ impl<D> NodeInner<D> {
     }
 }
 
-#[cfg(all(test, feature = "fs-store"))]
+#[cfg(test)]
 mod tests {
     use std::path::Path;
     use std::time::Duration;
@@ -387,4 +387,24 @@ mod tests {
 
         Ok(())
     }
+
+    #[cfg(feature = "fs-store")]
+    #[tokio::test]
+    async fn test_shutdown() -> Result<()> {
+        let _guard = iroh_test::logging::setup();
+
+        let iroh_root = tempfile::TempDir::new()?;
+        {
+            let iroh = Node::persistent(iroh_root.path()).await?.spawn().await?;
+            let doc = iroh.docs.create().await?;
+            drop(doc);
+            iroh.shutdown();
+            iroh.await?;
+        }
+
+        let iroh = Node::persistent(iroh_root.path()).await?.spawn().await?;
+        let _doc = iroh.docs.create().await?;
+
+        Ok(())
+    }
 }

iroh/src/node/builder.rs

@@ -438,13 +438,15 @@ where
             debug!(me = ?server.node_id(), "gossip initial update: {local_endpoints:?}");
             gossip.update_endpoints(&local_endpoints).ok();
         }
-
         loop {
             tokio::select! {
                 biased;
                 _ = cancel_token.cancelled() => {
                     // clean shutdown of the blobs db to close the write transaction
                     handler.inner.db.shutdown().await;
+                    if let Err(err) = handler.inner.sync.shutdown().await {
+                        warn!("sync shutdown error: {:?}", err);
+                    }
                     break
                 },
                 // handle rpc requests. This will do nothing if rpc is not configured, since