Merge pull request #18 from n-r-w/fix_cte_placeholder

fix cte PlaceholderFormat

Author: n-r-w

.golangci.yaml

@@ -37,8 +37,8 @@ linters-settings:
       - octalLiteral
       - whyNoLint
       - wrapperFunc
-      - unlabelStmt # выдает ошибку там где ее нет
-      - sloppyReassign # довольно странный линтер, предлагает выполнять "shadows declaration" внутри if
+      - unlabelStmt # false positive
+      - sloppyReassign # quite strange linter, suggests performing "shadows declaration" inside if.
     settings:
       # don't forget to run "golangci-lint cache clean" after changes in the .go files below
       hugeParam:

cte.go

@@ -53,8 +53,8 @@ func (d *commonTableExpressionsData) toSql() (sqlStr string, args []any, err err
 		return "", nil, err
 	}
 
-	sqlStr = sql.String()
-	return sqlStr, args, nil
+	sqlStr, err = d.PlaceholderFormat.ReplacePlaceholders(sql.String())
+	return sqlStr, args, err
 }
 
 func (d *commonTableExpressionsData) ToSql() (sql string, args []any, err error) {

cte_test.go

@@ -129,3 +129,25 @@ func TestWithAsQuery_Update(t *testing.T) {
 
 	assert.Equal(t, expectedSql, q)
 }
+
+func TestCTEPlaceholderFormat(t *testing.T) {
+	q := With("table1").As(
+		Select("col1", "col2").
+			From("table1").
+			Where(Eq{"col1": 1})).
+		Update(
+			Update("table2").
+				Set("col3", 2))
+
+	sql, _, err := q.PlaceholderFormat(Question).ToSql()
+	assert.NoError(t, err)
+
+	expectedSql := "WITH table1 AS (SELECT col1, col2 FROM table1 WHERE col1 = ?) UPDATE table2 SET col3 = ?"
+	assert.Equal(t, expectedSql, sql)
+
+	sql, _, err = q.PlaceholderFormat(Dollar).ToSql()
+	assert.NoError(t, err)
+
+	expectedSql = "WITH table1 AS (SELECT col1, col2 FROM table1 WHERE col1 = $1) UPDATE table2 SET col3 = $2"
+	assert.Equal(t, expectedSql, sql)
+}