Skip to content

Commit f15bd9f

Browse files
piecykmzgoddard
authored andcommitted
fix: remove ExcludeMiniCssModulePlugin
As mini-css-extract-plugin pass `emitFile` to child compilation webpack-contrib/mini-css-extract-plugin@18c066e
1 parent a250247 commit f15bd9f

File tree

3 files changed

+1
-49
lines changed

3 files changed

+1
-49
lines changed

index.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,10 +433,8 @@ class HardSourceWebpackPlugin {
433433
const TransformModuleErrorsPlugin = require('./lib/TransformModuleErrorsPlugin');
434434
const SupportExtractTextPlugin = require('./lib/SupportExtractTextPlugin');
435435
let SupportMiniCssExtractPlugin;
436-
let ExcludeMiniCssModulePlugin;
437436
if (webpackFeatures.generator) {
438437
SupportMiniCssExtractPlugin = require('./lib/SupportMiniCssExtractPlugin');
439-
ExcludeMiniCssModulePlugin = require('./lib/ExcludeMiniCssModulePlugin');
440438
}
441439
const TransformDependencyBlockPlugin = require('./lib/TransformDependencyBlockPlugin');
442440
const TransformBasicDependencyPlugin = require('./lib/TransformBasicDependencyPlugin');
@@ -479,7 +477,6 @@ class HardSourceWebpackPlugin {
479477

480478
if (SupportMiniCssExtractPlugin) {
481479
new SupportMiniCssExtractPlugin().apply(compiler);
482-
new ExcludeMiniCssModulePlugin().apply(compiler);
483480
}
484481

485482
new TransformDependencyBlockPlugin({

lib/ExcludeMiniCssModulePlugin.js

Lines changed: 0 additions & 45 deletions
This file was deleted.

tests/plugins-webpack-4.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describeWP(4)('plugin webpack 4 use', function() {
1919

2020
itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract');
2121
itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract', {exportStats: true});
22-
// itCompilesHardModules.skipIf([c.miniCss])('plugin-mini-css-extract', ['./index.css']);
22+
itCompilesHardModules.skipIf([c.miniCss])('plugin-mini-css-extract', ['./index.css']);
2323

2424
itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract-file');
2525
itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract-file', {exportStats: true});

0 commit comments

Comments
 (0)