Possible to update Adplug or allow external one? (bundled one broken on Big-endian platforms)

[barracuda156]

The bundled version is broken on Big-endian platforms.
This issue has been fixed upstream: adplug/adplug#247

It is possible either to update to a fixed version or provide a configure option, so that external adplug can be used?

[mywave82]

OCP has a patch-set on-top av vanilla Adplug, to extract internal information that is not available in the API. If you want to build with a newer adplug, you will need to apply that patch set manually.

adplug/adplug@master...mywave82:adplug:ocp-v3.0.1
needs to be rebased on the adplug master branch.

I have been a bit busy the last months, but plan to get some updates to OCP in the near future; and I usually update adplug and libsidplayfp on each release of OCP.

[barracuda156]

@mywave82 I see, thank you. Why did you disable an option to disable adplug though? It is there in configure, but commented out.

[mywave82]

Because of the patch-set that we put on top. Adplug upstream did not want to expose that internal data in the API.

[barracuda156]

Because of the patch-set that we put on top. Adplug upstream did not want to expose that internal data in the API.

I mean, it is certainly possible to build opencubicplayer without adplug (whether external or bundled). It seems that configure had --with-adplug before (which also implied --without-adplug), but that option was commented out.