Skip to content

Commit f654e23

Browse files
committed
Updated tab elements
1 parent 88f76e9 commit f654e23

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

src/index.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,16 @@
5050

5151
<div class="container">
5252
<h1>Tab Group</h1>
53-
53+
<div style="background-color: var(--grey-10-color); padding: 5px;">
5454
<wc-tab-group backgroundColor="light">
5555
<wc-tab name="tab-tables" selected>Tables</wc-tab>
5656
<wc-tab name="tab-buttons">Buttons</wc-tab>
5757
<wc-tab name="tab-badges">Badges</wc-tab>
5858
<wc-tab name="tab-icons">Icons</wc-tab>
59-
<wc-tab name="tab-disabled" disabled>Disabled</wc-tab>
59+
<wc-tab name="tab-disabled" disabled><wc-icon name="person-circle" size="medium"></wc-icon> Disabled</wc-tab>
6060
</wc-tab-group>
6161
</div>
62+
</div>
6263
<hr>
6364

6465
<div class="container">

src/nav/TabElement.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,10 @@ export class TabElement extends LitElement {
5252
static get styles() {
5353
return css`
5454
li {
55-
text-align: center;
55+
vertical-align: middle;
56+
}
57+
li.selected {
58+
border-bottom: 2px solid var(--error-color);
5659
}
5760
`;
5861
}

src/nav/TabGroupElement.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,9 @@ export class TabGroupElement extends LitElement {
142142
tabs.forEach((tab) => {
143143
if (tab.name === name && !tab.disabled) {
144144
if (!tab.selected) {
145-
console.log('SELECT', tab.name);
146-
tab.selected = true;
145+
tab.setAttribute('selected', true);
147146
}
148147
} else if (tab.selected) {
149-
console.log('DESELECT', tab.name);
150148
tab.selected = false;
151149
}
152150
});

0 commit comments

Comments
 (0)