Skip to content

"Computing the diff for you" - editor hangs #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuintinS opened this issue Aug 29, 2017 · 3 comments
Open

"Computing the diff for you" - editor hangs #131

QuintinS opened this issue Aug 29, 2017 · 3 comments

Comments

@QuintinS
Copy link

QuintinS commented Aug 29, 2017

I found split-diff to solve a problem I was having, since it seemed like the ideal tool.

I used as described... opened the file, ran "split diff: toggle"... but all I get is a loading message saying "Computing the diff for you" which crashes the editor, necessitating a force-quit.

I've seen other issues with similar results dating back to 2016.

Atom: 1.19.2
Split-diff: 1.5.1

@mupchrch
Copy link
Owner

@QuintinS any chance you can reproduce with the console open? (ctrl+shift+p then search dev tools) Then if you run split-diff, does the console say anything? Does it happen on all files or specific files? Thanks

@ghost
Copy link

ghost commented Oct 13, 2017

@mupchrch I'm also seeing this issue.

I ran it with dev tools open and the only thing I see is this but that was there before running split diff

IntersectionObserver.observe(target): target element is not a descendant of root.

It's seems to only happen to me on large files eg I'm trying to diff a file that's 52,000 lines.

In task manager there is a atom process that's at 9.9% CPU and 700MB of RAM. the usage is only hitting one process on the 12 the system has (ryzen system).

I let it run on the "Computing the diff for you" for 45 mins then force quite atom.

Atom: 1.21.1
Split-diff: 1.5.1

@XaviLC
Copy link

XaviLC commented Apr 9, 2018

I am experiencing the same issue but with split-diff 1.5.2
Using console shows this

[Violation] Forced reflow while executing JavaScript took 43ms
[Violation] Forced reflow while executing JavaScript took 66ms
C:\Users\jj.atom\packages\minimap\lib\minimap-element.js:779 [Violation] 'requestAnimationFrame' handler took 62ms
[Violation] 'requestAnimationFrame' handler took 78ms
[Violation] Forced reflow while executing JavaScript took 45ms
C:\Users\jj.atom\packages\minimap\lib\minimap-element.js:779 [Violation] 'requestAnimationFrame' handler took 63ms
C:\Users\jj.atom\packages\minimap\lib\minimap-element.js:779 [Violation] 'requestAnimationFrame' handler took 56ms
C:\Users\jj.atom\packages\minimap\lib\minimap-element.js:779 [Violation] 'requestAnimationFrame' handler took 52ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants