Fix setAnalogControlState

[LosFaul]

Edit: i cleaned up this topic, because it was a mess before

Is your feature request related to a problem? Please describe.
setAnalogControlState is not working when there is actual player input.

addEventHandler("onClientPreRender", root,
    function()
        local accelerate = getAnalogControlState("accelerate")
        setAnalogControlState("accelerate", accelerate * 0.1)
    end
)

in this example i try to modify the player input,
but setAnalogControlState has no effect

Describe the solution you'd like
Fix setAnalogControlState, so that it allows to modify player input

[LosFaul]

this is a bump with another example:
reversing controls

addEventHandler("onClientPreRender", root,
    function()
        -- get controll values
        local left = getAnalogControlState("vehicle_left")
        local right = getAnalogControlState("vehicle_right")
        -- reverse controll values
        setAnalogControlState("vehicle_left", right)
        setAnalogControlState("vehicle_right", left)
    end
)

this does not work either

you can it get working for keyboards but not for gamepads as gamepads will bypass it
keyboard solution would be currently to unbind controll keys and make and own check if the keys are pressed

but if the issue would be fixed keyboard and gamepads would share the same solution

[LosFaul]

I thought a bit how a potential solution could be done.
Keeping the game process order in mind: https://wiki.multitheftauto.com/wiki/Game_Processing_Order
and not trying to break existing scripts

a solution could look like this:

setAnalogControlState(string controll, float value[, forced = false])

the solution would be to add a third optional argument which is per default false
this is in order to not break existing scripts
if forced is true
the value is ensured to be used for the next game position update
and after the position update it should work normally again
so that you can get after the game position update in onClientPreRender event the player input and be able to transform it again

[qaisjp]

The API you propose sounds good to me.

[LosFaul]

i figured out player input update happens between onClientHUDRender and onClientRender
which is actually a bit questionable placement for player input update

but the issue still remains you can't transform player input with scripting

Fixed in #1852