Skip to content

Premake buildactions always return status code 0 #1293

Closed
@qaisjp

Description

@qaisjp

Describe the bug

install_cef failed to download CEF yet the build step still succeeds https://github.com/multitheftauto/mtasa-blue/runs/507985212#step:6:6

this is because our buildactions always return status code 0

To reproduce

Edit the install_cef buildaction and change the mirror.mtasa.com url to some garbage. Run

Expected behaviour

exit with status code 1 if an error occurs.

Screenshots

Version

v1.5.7 master 4b7432e

Additional context

this issue almost certainly exists in other places too. maybe some of our non-lua scripts too.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions