Use new argument parser for generic server functions (PR #2110)

Co-authored-by: Pirulax <patrikjankovics7@gmail.com>

Author: botder

Server/mods/deathmatch/logic/CMainConfig.cpp

@@ -886,15 +886,17 @@ bool CMainConfig::IsValidPassword(const char* szPassword)
 
 bool CMainConfig::SetPassword(const char* szPassword, bool bSave)
 {
-    if (IsValidPassword(szPassword))
+    if (!IsValidPassword(szPassword))
+        return false;
+
+    m_strPassword = szPassword;
+
+    if (bSave)
     {
-        m_strPassword = szPassword;
-        if (bSave)
-        {
-            SetString(m_pRootNode, "password", szPassword);
-            Save();
-        }
+        SetString(m_pRootNode, "password", szPassword);
+        Save();
     }
+
     return true;
 }
 

Server/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp

@@ -10062,22 +10062,19 @@ void CStaticFunctionDefinitions::OutputChatBox(const char* szText, const std::ve
     CPlayerManager::Broadcast(CChatEchoPacket(szText, ucRed, ucGreen, ucBlue, bColorCoded), sendList);
 }
 
-bool CStaticFunctionDefinitions::ClearChatBox(CElement* pElement)
+void CStaticFunctionDefinitions::ClearChatBox(CElement* pElement)
 {
     assert(pElement);
-
     RUN_CHILDREN(ClearChatBox(*iter))
 
     if (IS_PLAYER(pElement))
     {
         CPlayer* pPlayer = static_cast<CPlayer*>(pElement);
         pPlayer->Send(CChatClearPacket());
-        return true;
     }
-    return false;
 }
 
-bool CStaticFunctionDefinitions::OutputConsole(const char* szText, CElement* pElement)
+void CStaticFunctionDefinitions::OutputConsole(const char* szText, CElement* pElement)
 {
     assert(pElement);
     assert(szText);
@@ -10087,10 +10084,7 @@ bool CStaticFunctionDefinitions::OutputConsole(const char* szText, CElement* pEl
     {
         CPlayer* pPlayer = static_cast<CPlayer*>(pElement);
         pPlayer->Send(CConsoleEchoPacket(szText));
-        return true;
     }
-
-    return false;
 }
 
 bool CStaticFunctionDefinitions::SetServerPassword(const SString& strPassword, bool bSave)
@@ -10101,6 +10095,7 @@ bool CStaticFunctionDefinitions::SetServerPassword(const SString& strPassword, b
             CLogger::LogPrintf("Server password set to '%s'\n", *strPassword);
         else
             CLogger::LogPrintf("Server password cleared\n");
+
         return true;
     }
 

Server/mods/deathmatch/logic/CStaticFunctionDefinitions.h

@@ -562,9 +562,9 @@ class CStaticFunctionDefinitions
                               CLuaMain* pLuaMain);
     static void OutputChatBox(const char* szText, const std::vector<CPlayer*>& sendList, unsigned char ucRed, unsigned char ucGreen, unsigned char ucBlue,
                               bool bColorCoded);
-    static bool OutputConsole(const char* szText, CElement* pElement);
+    static void OutputConsole(const char* szText, CElement* pElement);
     static bool SetServerPassword(const SString& strPassword, bool bSave);
-    static bool ClearChatBox(CElement* pElement);
+    static void ClearChatBox(CElement* pElement);
 
     // General world get funcs
     static bool GetTime(unsigned char& ucHour, unsigned char& ucMinute);