Fix #1043: Change bad numberstring warning to error

patrikjuvonen · patrikjuvonen · commit 9baf6a5b6b3f · 2022-12-24T16:31:11.000+02:00
diff --git a/Shared/sdk/CScriptArgReader.h b/Shared/sdk/CScriptArgReader.h
@@ -59,7 +59,8 @@ class CScriptArgReader
             // The string received may not actually be a number
             if (!lua_isnumber(m_luaVM, m_iIndex))
             {
-                SetCustomWarning("Expected number, got non-convertible string. This warning may be an error in future versions.");
+                SetCustomError("Expected number, got non-convertible string", "Bad argument");
+                return;
             }
 
             // Returns 0 even if the string cannot be parsed as a number
@@ -103,7 +104,8 @@ class CScriptArgReader
             // The string received may not actually be a number
             if (!lua_isnumber(m_luaVM, m_iIndex))
             {
-                SetCustomWarning("Expected number, got non-convertible string. This warning may be an error in future versions.");
+                SetCustomError("Expected number, got non-convertible string", "Bad argument");
+                return;
             }
 
             // Returns 0 even if the string cannot be parsed as a number

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,8 @@ class CScriptArgReader`
`59`	`59`	`// The string received may not actually be a number`
`60`	`60`	`if (!lua_isnumber(m_luaVM, m_iIndex))`
`61`	`61`	`{`
`62`		`- SetCustomWarning("Expected number, got non-convertible string. This warning may be an error in future versions.");`
	`62`	`+ SetCustomError("Expected number, got non-convertible string", "Bad argument");`
	`63`	`+ return;`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`// Returns 0 even if the string cannot be parsed as a number`
`@@ -103,7 +104,8 @@ class CScriptArgReader`
`103`	`104`	`// The string received may not actually be a number`
`104`	`105`	`if (!lua_isnumber(m_luaVM, m_iIndex))`
`105`	`106`	`{`
`106`		`- SetCustomWarning("Expected number, got non-convertible string. This warning may be an error in future versions.");`
	`107`	`+ SetCustomError("Expected number, got non-convertible string", "Bad argument");`
	`108`	`+ return;`
`107`	`109`	`}`
`108`	`110`
`109`	`111`	`// Returns 0 even if the string cannot be parsed as a number`