Synchronize changes from 1.6 master branch [ci skip]

08e1f85 Fix building LOD's crash (#3513)

Author: github-actions[bot]

Client/mods/deathmatch/logic/CClientBuilding.cpp

@@ -24,6 +24,7 @@ CClientBuilding::CClientBuilding(class CClientManager* pManager, ElementID ID, u
       m_pLowBuilding(nullptr)
 {
     m_pManager = pManager;
+    m_pModelInfo = g_pGame->GetModelInfo(usModelId);
     SetTypeName("building");
     m_pBuildingManager->AddToList(this);
     Create();
@@ -99,6 +100,7 @@ void CClientBuilding::SetModel(uint16_t model)
     if (CClientBuildingManager::IsValidModel(model))
     {
         m_usModelId = model;
+        m_pModelInfo = g_pGame->GetModelInfo(model);
         Recreate();
     }
 }

Client/mods/deathmatch/logic/CClientBuildingManager.cpp

@@ -98,9 +98,38 @@ void CClientBuildingManager::DestroyAllForABit()
 
 void CClientBuildingManager::RestoreDestroyed()
 {
-    for (CClientBuilding* building : GetBuildings())
+    bool hasInvalidLods = true;
+    while (hasInvalidLods)
     {
-        building->Create();
+        hasInvalidLods = false;
+        for (CClientBuilding* building : GetBuildings())
+        {
+            const CClientBuilding* highLodBuilding = building->GetHighLodBuilding();
+            if (highLodBuilding && !highLodBuilding->IsValid())
+            {
+                hasInvalidLods = true;
+            }
+            else
+            {
+                CModelInfo* modelInfo = building->GetModelInfo();
+                const uint16_t physicalGroup = modelInfo->GetObjectPropertiesGroup();
+
+                if (physicalGroup == -1)
+                {
+                    building->Create();
+                }
+                else
+                {
+                    // GTA creates dynamic models as dummies.
+                    // It's possible that the physical group was changes after
+                    // creating a new building. We can avoid crashes in this case.
+                    modelInfo->SetObjectPropertiesGroup(-1);
+                    building->Create();
+                    modelInfo->SetObjectPropertiesGroup(physicalGroup);
+                }
+                
+            }
+        }
     }
 }