Improve prompt for locked files during update

Author: botder

Client/loader/Install.cpp

@@ -239,42 +239,50 @@ static bool TerminateFileLockingProcesses(const SString& absolutePath, const SSt
     WString            filePath(absolutePath);
     std::vector<DWORD> processIds = GetProcessListUsingFile(filePath);
 
-    if (processIds.empty())
-        return true;
+    while (true)
+    {
+        if (processIds.empty())
+            return true;
 
-    SString nameList;
+        SString nameList;
 
-    for (DWORD processId : processIds)
-    {
-        if (!nameList.empty())
-            nameList += '\n';
+        for (DWORD processId : processIds)
+        {
+            if (!nameList.empty())
+                nameList += '\n';
 
-        SString processName = GetProcessFilename(processId);
+            SString processName = GetProcessFilename(processId);
 
-        if (processName.empty())
-            processName = _("Unknown");
+            if (processName.empty())
+                processName = _("Unknown");
 
-        nameList += SString("   %s  [%lu]", processName.c_str(), processId);
-    }
+            nameList += SString("   %s  [%lu]", processName.c_str(), processId);
+        }
 
-    int decision = MessageBoxUTF8(
-        nullptr,
-        SString(_("The file '%s' is currently locked by %zu processes.\n\nDo you want to terminate the following processes and continue updating?\n\n%s"),
-                displayName.c_str(), processIds.size(), nameList.c_str()),
-        "MTA: San Andreas", MB_YESNO | MB_ICONQUESTION | MB_TOPMOST);
+        int decision = MessageBoxUTF8(
+            nullptr,
+            SString(_("The file '%s' is currently locked by %zu processes.\n\nDo you want to terminate the following processes and continue updating?\n\n%s"),
+                    displayName.c_str(), processIds.size(), nameList.c_str()),
+            "MTA: San Andreas", MB_CANCELTRYCONTINUE | MB_ICONQUESTION | MB_TOPMOST);
 
-    if (decision != IDYES)
-        return false;
+        processIds = GetProcessListUsingFile(filePath);
 
-    for (DWORD processId : processIds)
-    {
-        if (!TerminateProcess(processId, 0))
+        if (processIds.empty())
+            return true;
+
+        if (decision == IDTRYAGAIN)
+            continue;
+
+        if (decision != IDCONTINUE)
+            return false;
+
+        for (DWORD processId : processIds)
         {
-            AddReportLog(5055, SString("TerminateFileLockingProcesses: Failed to terminate process '%s' (%lu)", GetProcessPathFilename(processId), processId));
+            TerminateProcess(processId, 0);
         }
-    }
 
-    return GetProcessListUsingFile(filePath).empty();
+        processIds = GetProcessListUsingFile(filePath);
+    }
 }
 
 /**