Revert "Fix MD5 checksum for empty buffers"

botder · botder · commit 4977bd518827 · 2021-08-16T18:49:07.000+02:00
This reverts commit 4b15cc3.
diff --git a/Shared/sdk/CChecksum.h b/Shared/sdk/CChecksum.h
@@ -66,10 +66,7 @@ class CChecksum
     {
         CChecksum result;
         result.ulCRC = CRCGenerator::GetCRCFromBuffer(cpBuffer, ulLength);
-
-        if (result.ulCRC != 0)
-            CMD5Hasher().Calculate(cpBuffer, ulLength, result.md5);
-        
+        CMD5Hasher().Calculate(cpBuffer, ulLength, result.md5);
         return result;
     }
 
diff --git a/Shared/sdk/SharedUtil.Hash.hpp b/Shared/sdk/SharedUtil.Hash.hpp
@@ -145,9 +145,6 @@ namespace SharedUtil
 
     void CMD5Hasher::Update(unsigned char* input, unsigned int input_length)
     {
-        if (input_length == 0)
-            return;
-        
         // CRYPT_START
         unsigned int input_index, buffer_index;
         unsigned int buffer_space;            // how much space is left in buffer

Original file line number	Diff line number	Diff line change
`@@ -66,10 +66,7 @@ class CChecksum`
`66`	`66`	`{`
`67`	`67`	`CChecksum result;`
`68`	`68`	`result.ulCRC = CRCGenerator::GetCRCFromBuffer(cpBuffer, ulLength);`
`69`		`-`
`70`		`- if (result.ulCRC != 0)`
`71`		`- CMD5Hasher().Calculate(cpBuffer, ulLength, result.md5);`
`72`		`-`
	`69`	`+ CMD5Hasher().Calculate(cpBuffer, ulLength, result.md5);`
`73`	`70`	`return result;`
`74`	`71`	`}`
`75`	`72`
Original file line number	Diff line number	Diff line change
`@@ -145,9 +145,6 @@ namespace SharedUtil`
`145`	`145`
`146`	`146`	`void CMD5Hasher::Update(unsigned char* input, unsigned int input_length)`
`147`	`147`	`{`
`148`		`- if (input_length == 0)`
`149`		`- return;`
`150`		`-`
`151`	`148`	`// CRYPT_START`
`152`	`149`	`unsigned int input_index, buffer_index;`
`153`	`150`	`unsigned int buffer_space; // how much space is left in buffer`