Potential fix of #1613 (#2198)

Test crashfix for pools / custom map crashes 0x0013368b, 0x00144bc8 and 0x00142721
Read both #1613 and #2198 for more info

Author: tederis

Client/game_sa/CEntitySA.h

@@ -120,7 +120,7 @@ class CPlaceableSAInterface            // 20 bytes
 {
 public:
     CSimpleTransformSAInterface m_transform;
-    CMatrix_Padded*             matrix;            // This is actually XYZ*, change later
+    CMatrix_Padded*             matrix;            // This is actually XYZ*, change later   
 };
 
 class CEntitySAInterface

Client/game_sa/CFileLoaderSA.cpp

@@ -15,6 +15,7 @@ void CFileLoaderSA::StaticSetHooks()
 {
     HookInstall(0x5371F0, (DWORD)CFileLoader_LoadAtomicFile, 5);
     HookInstall(0x537150, (DWORD)CFileLoader_SetRelatedModelInfoCB, 5);
+    HookInstall(0x538690, (DWORD)CFileLoader_LoadObjectInstance, 5);
 }
 
 class CAtomicModelInfo
@@ -159,3 +160,35 @@ RpAtomic* CFileLoader_SetRelatedModelInfoCB(RpAtomic* atomic, SRelatedModelInfo*
     }
     return atomic;
 }
+
+CEntitySAInterface* CFileLoader_LoadObjectInstance(const char* szLine)
+{
+    char szModelName[24];
+    SFileObjectInstance inst;
+
+    sscanf(
+        szLine,
+        "%d %s %d %f %f %f %f %f %f %f %d",
+        &inst.modelID,
+        szModelName,
+        &inst.interiorID,
+        &inst.position.fX,
+        &inst.position.fY,
+        &inst.position.fZ,
+        &inst.rotation.fX,
+        &inst.rotation.fY,
+        &inst.rotation.fZ,
+        &inst.rotation.fW,
+        &inst.lod
+    );
+
+    /*
+       A quaternion is must be normalized. GTA is relying on an internal R* exporter and everything is OK,
+       but custom exporters might not contain the normalization. And we must do it yourself.
+   */
+    const float fLenSq = inst.rotation.LengthSquared();
+    if (fLenSq > 0.0f && std::fabs(fLenSq - 1.0f) > std::numeric_limits<float>::epsilon())
+        inst.rotation /= std::sqrt(fLenSq);
+
+    return ((CEntitySAInterface*(__cdecl*)(SFileObjectInstance*))0x538090)(&inst);
+}

Client/game_sa/CFileLoaderSA.h

@@ -6,6 +6,15 @@ struct SRelatedModelInfo
     bool bDeleteOldRwObject;
 };
 
+struct SFileObjectInstance
+{
+    CVector     position;
+    CVector4D   rotation;
+    int         modelID;
+    int         interiorID;
+    int         lod;
+};
+
 class CFileLoaderSA
 {
 public:
@@ -17,3 +26,4 @@ class CFileLoaderSA
 
 bool CFileLoader_LoadAtomicFile(RwStream *stream, unsigned int modelId);
 RpAtomic* CFileLoader_SetRelatedModelInfoCB(RpAtomic* atomic, SRelatedModelInfo* pRelatedModelInfo);
+CEntitySAInterface* CFileLoader_LoadObjectInstance(const char* szLine);

Client/game_sa/CGameSA.cpp

@@ -196,6 +196,7 @@ CGameSA::CGameSA()
     m_pPools->SetPoolCapacity(ENV_MAP_ATOMIC_POOL, 4000);                                     // Default is 1024
     m_pPools->SetPoolCapacity(SPEC_MAP_MATERIAL_POOL, 16000);                                 // Default is 4096
     m_pPools->SetPoolCapacity(ENTRY_INFO_NODE_POOL, MAX_ENTRY_INFO_NODES);                    // Default is 500
+    m_pPools->SetPoolCapacity(POINTER_SINGLE_LINK_POOL, MAX_POINTER_SINGLE_LINKS);            // Default is 70000
     m_pPools->SetPoolCapacity(POINTER_DOUBLE_LINK_POOL, MAX_POINTER_DOUBLE_LINKS);            // Default is 3200
     dassert(m_pPools->GetPoolCapacity(POINTER_SINGLE_LINK_POOL) == MAX_POINTER_SINGLE_LINKS);
 

Client/sdk/game/Common.h

@@ -19,7 +19,7 @@
 #define MAX_PEDS_MTA                        110         // Real limit is 140
 #define MAX_OBJECTS_MTA                     1000        // Real limit is 1200
 #define MAX_ENTRY_INFO_NODES_MTA            72000       // Real limit is 72600  ( MAX_OBJECTS_MTA * 72 ) [Large col models are the cause of high usage]
-#define MAX_POINTER_SINGLE_LINKS_MTA        65000       // Real limit is 70000
+#define MAX_POINTER_SINGLE_LINKS_MTA        85000       // Real limit is 90000 [Large col models are the cause of high usage]
 #define MAX_POINTER_DOUBLE_LINKS_MTA        74000       // Real limit is 74800  ( MAX_OBJECTS_MTA * 72 + 2000 )
 
 // Real limits for GTA
@@ -28,7 +28,7 @@
 #define MAX_OBJECTS                         ( MAX_OBJECTS_MTA + 200 )               // 1200
 #define MAX_BUILDINGS                       13000
 #define MAX_ENTRY_INFO_NODES                ( MAX_ENTRY_INFO_NODES_MTA + 600 )      // 72600
-#define MAX_POINTER_SINGLE_LINKS            ( MAX_POINTER_SINGLE_LINKS_MTA + 5000 ) // 70000
+#define MAX_POINTER_SINGLE_LINKS            ( MAX_POINTER_SINGLE_LINKS_MTA + 5000 ) // 90000
 #define MAX_POINTER_DOUBLE_LINKS            ( MAX_POINTER_DOUBLE_LINKS_MTA + 800 )  // 74800
 #define MAX_RWOBJECT_INSTANCES              2500