Skip to content

Commit 3a25cce

Browse files
committed
Fix Win32 compile error
1 parent 9883704 commit 3a25cce

File tree

5 files changed

+16
-22
lines changed

5 files changed

+16
-22
lines changed

Client/mods/deathmatch/logic/lua/CLuaArgument.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ bool CLuaArgument::CompareRecursive(const CLuaArgument& Argument, std::set<CLuaA
176176
if (m_pTableData->Count() != Argument.m_pTableData->Count())
177177
return false;
178178

179-
vector<CLuaArgument*>::const_iterator iter = m_pTableData->IterBegin();
180-
vector<CLuaArgument*>::const_iterator iterCompare = Argument.m_pTableData->IterBegin();
181-
while (iter != m_pTableData->IterEnd() && iterCompare != Argument.m_pTableData->IterEnd())
179+
vector<CLuaArgument*>::const_iterator iter = m_pTableData->begin();
180+
vector<CLuaArgument*>::const_iterator iterCompare = Argument.m_pTableData->begin();
181+
while (iter != m_pTableData->end() && iterCompare != Argument.m_pTableData->end())
182182
{
183183
if (pKnownTables->find(m_pTableData) == pKnownTables->end())
184184
{

Client/mods/deathmatch/logic/lua/CLuaArguments.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,11 +191,9 @@ void CLuaArguments::PushAsTable(lua_State* luaVM, CFastHashMap<CLuaArguments*, i
191191

192192
void CLuaArguments::PushArguments(const CLuaArguments& Arguments)
193193
{
194-
vector<CLuaArgument*>::const_iterator iter = Arguments.IterBegin();
195-
for (; iter != Arguments.IterEnd(); iter++)
194+
for (CLuaArgument* arg : Arguments)
196195
{
197-
CLuaArgument* pArgument = new CLuaArgument(**iter);
198-
m_Arguments.push_back(pArgument);
196+
m_Arguments.push_back(new CLuaArgument(*arg));
199197
}
200198
}
201199

Client/mods/deathmatch/logic/luadefs/CLuaBrowserDefs.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,10 +1030,10 @@ int CLuaBrowserDefs::SetBrowserAjaxHandler(lua_State* luaVM)
10301030

10311031
arguments.Call(pLuaMain, callbackFunction, &result);
10321032

1033-
if (result.Count() == 0)
1033+
if (result.IsEmpty())
10341034
return "";
10351035

1036-
CLuaArgument* returnedValue = *result.IterBegin();
1036+
CLuaArgument* returnedValue = *result.begin();
10371037
if (returnedValue->GetType() == LUA_TSTRING)
10381038
return returnedValue->GetString();
10391039
else

Client/mods/deathmatch/logic/luadefs/CLuaGUIDefs.cpp

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2360,13 +2360,11 @@ int CLuaGUIDefs::GUIGridListAddRow(lua_State* luaVM)
23602360
else
23612361
{
23622362
// Vector containing our string arguments. We add a bool to store whether it was originally a number.
2363-
std::vector<std::pair<SString, bool> > m_items;
2364-
std::vector<CLuaArgument*>::const_iterator it = Arguments.IterBegin();
2365-
for (it; it != Arguments.IterEnd(); it++)
2363+
std::vector<std::pair<SString, bool>> m_items;
2364+
for (CLuaArgument* pArgument : Arguments)
23662365
{
2367-
CLuaArgument* pArgument = *it;
2368-
SString strItemText;
2369-
bool bNumber = false;
2366+
SString strItemText;
2367+
bool bNumber = false;
23702368

23712369
// Check the type of the argument and convert it to a string we can process
23722370
uint type = pArgument->GetType();
@@ -2427,12 +2425,10 @@ int CLuaGUIDefs::GUIGridListInsertRowAfter(lua_State* luaVM)
24272425
{
24282426
// Vector containing our string arguments. We add a bool to store whether it was originally a number.
24292427
std::vector<std::pair<SString, bool> > m_items;
2430-
std::vector<CLuaArgument*>::const_iterator it = Arguments.IterBegin();
2431-
for (it; it != Arguments.IterEnd(); it++)
2428+
for (CLuaArgument* pArgument : Arguments)
24322429
{
2433-
CLuaArgument* pArgument = *it;
2434-
SString strItemText;
2435-
bool bNumber = false;
2430+
SString strItemText;
2431+
bool bNumber = false;
24362432

24372433
// Check the type of the argument and convert it to a string we can process
24382434
uint type = pArgument->GetType();

Client/mods/deathmatch/logic/luadefs/CLuaResourceDefs.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,9 +488,9 @@ int CLuaResourceDefs::Load(lua_State* luaVM)
488488
{
489489
CLuaArguments returnValues;
490490
callbackArguments.Call(pLuaMain, iLuaFunction, &returnValues);
491-
if (returnValues.Count())
491+
if (returnValues.IsNotEmpty())
492492
{
493-
CLuaArgument* returnedValue = *returnValues.IterBegin();
493+
CLuaArgument* returnedValue = *returnValues.begin();
494494
int iType = returnedValue->GetType();
495495
if (iType == LUA_TNIL)
496496
break;

0 commit comments

Comments
 (0)