-
Notifications
You must be signed in to change notification settings - Fork 52
Description
First of all thank you for this tool, it helped me fixed CODEOWNERS
for https://github.com/godotengine/godot
Turns out that review-requests don't work for teams without Write
permission for some reason (as if a review from someone not able to press "Merge" is not valid), but your tool caught it + more issues :)
Version
0.6.0, installed in ./bin
with curl instructions.
Description
There seems to be a false positive report from the File Exist Checker when using relative paths which are then checked in all directories by CODEOWNERS
.
What I mean is what is described here: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
# In this example, @octocat owns any file in an apps directory
# anywhere in your repository.
apps/ @octocat
This will successfully match apps/
directories in any directory of the repository, even if there's no apps/
directory in the root.
But codeowners-validator
issues a warning about this case.
Expected result
No warning if any nested directory matches the pattern.
Actual result
==> Executing File Exist Checker (45.227677ms)
[err] line 11: "SCsub" does not match any files in repository
[err] line 23: "doc_classes/*" does not match any files in repository
Yet:
$ find -type f -name SCsub | wc -l
124
$ find -type d -name doc_classes | wc -l
19
(This is on https://github.com/godotengine/godot/)
Steps to reproduce
- Clone https://github.com/godotengine/godot/
env REPOSITORY_PATH="." OWNER_CHECKER_REPOSITORY="godotengine/godot" ./bin/codeowners-validator
Troubleshooting
n/a