Skip to content

Commit 30d997e

Browse files
thedavekwonfacebook-github-bot
authored andcommitted
Avoid copying type::Type and update comments for AnyPatchExtractionVisitor
Summary: We are not pursuing splitting any more. Remove TODO comment. Reviewed By: Mizuchi Differential Revision: D67963820 fbshipit-source-id: d2380f70f2ed630e63b4533690e363827b05e50d
1 parent 00e0f4d commit 30d997e

File tree

1 file changed

+1
-4
lines changed
  • third-party/thrift/src/thrift/lib/thrift/detail

1 file changed

+1
-4
lines changed

third-party/thrift/src/thrift/lib/thrift/detail/AnyPatch.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,6 @@ class AnyPatch : public BaseClearPatch<Patch, AnyPatch<Patch>> {
255255

256256
void apply(type::AnyData& val) const { apply(val.toThrift()); }
257257

258-
// TODO(dokwon): Consider migrating it to be part of patch splitting when it
259-
// is available.
260-
261258
/// Extracts the patch for the given patch type.
262259
template <typename VPatch>
263260
VPatch extractPatchAsIf() const {
@@ -287,7 +284,7 @@ class AnyPatch : public BaseClearPatch<Patch, AnyPatch<Patch>> {
287284
}
288285

289286
VPatch patch;
290-
const type::Type type_ = type::Type::get<VTag>();
287+
const type::Type& type_ = type::Type::get<VTag>();
291288
};
292289
AnyPatchExtractionVisitor visitor;
293290
customVisit(visitor);

0 commit comments

Comments
 (0)