Shouldn't smartcase match the case of replaced?

[kasbah]

Hello! I love sad! In the README it says:

By default, sad uses smartcase,

To me this would mean that:

Bye

bye

and sad bye goodbye

would become

Goodbye

goodbye

but it actually becomes:

goodbye

goodbye

Is this intended? Maybe it should be clarified in the the README?

[danie-dejager]

I also thought that the case will be preserved. It does make sense for the final case to be the replacement value. Changing with the following example makes it a bit more confusing

fd test1.sh | sad -e goodbye bye
-goodbye
-Goodbye
+bye    
+bye

fd test1.sh | sad -e Goodbye bye
 goodbye
-Goodbye
+bye

where sad -fI -e goodbye bye

-goodbye 
+bye     
 Goodbye 

should there be an option to preserve case using smartcase default? Maybe but it should not be the default behaviour. The intended change should by default end-up with the exact replacement value as it was given.

[kasbah]

It does make sense for the final case to be the replacement value.

Isn't that more accurately described as a case-insensitive replacement rather than smart case though?