Replies: 1 comment
-
Opened an issue for this: #800 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Checked other resources
Feature description
Hi,
I would really love to see this one working in rustaceanvim: https://rust-analyzer.github.io/book/assists.html#extract_function
I took a quick look into it. As you can see the extract function will quit right away if the selection range is empty:
https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-assists/src/handlers/extract_function.rs#L67
While rustaceanvim is not sending the selection range to the language server:
https://github.com/mrcjkb/rustaceanvim/blob/master/lua/rustaceanvim/commands/code_action_group.lua#L400
Actually I've patched code_action_group() quickly, and it seems the rest is fine, the lsp response is handled ok.
Beta Was this translation helpful? Give feedback.
All reactions