Skip to content

Conversation

@Nextra
Copy link

@Nextra Nextra commented Aug 18, 2023

This changes the flow of ipFromRequest to run all remoteIP candidates through net.SplitPortHost (if applicable) regardless of source, instead of treating http.Request.RemoteAddr as the lone special case.

The motivation behind this is that Azure Application Gateways add the X-Forwarded-For header as a comma separated list of IP:port instead of each entry just containing the IP address (ref), making it unnecessarily difficult to deploy echoip as-is to Azure Web App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant