-
Notifications
You must be signed in to change notification settings - Fork 81
Description
There are a handful of utility mixins sometimes serving "interesting" prefixed rules:
protocol/assets/sass/protocol/includes/mixins/_utils.scss
Lines 101 to 114 in 1241924
| @mixin align-items($align: stretch) { | |
| -webkit-box-align: $align; | |
| align-items: $align; | |
| } | |
| @mixin justify-content($justify: flex-start) { | |
| -webkit-box-pack: $justify; | |
| justify-content: $justify; | |
| } | |
| @mixin background-size($sizes...) { | |
| -webkit-background-size: $sizes; | |
| background-size: $sizes; | |
| } |
(e.g. align-items is unprefixed since Safari 9, and Safari 8 had it prefixed, but the fallback to *-box-align i.e. another experimental property sounds rather complex for today's use; -webkit-background-size had a different logic applied to param count and didn't understand a handful of values etc.)
While definitely intriguing piece of code that must have been really helpful in the past decade, some bits are probably no longer relevant or necessary, and if used, only inflating the compiled output with no positive impact. Maybe it's time to audit if/where these are being used, and plan a decommission path to have them removed one day.
If a major/breaking release is coming up, that might help justifying some of the mixin removal, if they no longer serve the purpose and would just need to be kept around passing through the stable property for backwards compatibility of the API.