Skip to content

Commit a9cddfa

Browse files
authored
Add spec reference comments
Specifically for for AV1ConfigBox struct, read_av1c and read_hdlr
1 parent e8be415 commit a9cddfa

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

mp4parse/src/lib.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,6 +473,7 @@ pub struct VPxConfigBox {
473473
pub codec_init: TryVec<u8>,
474474
}
475475

476+
/// See AV1-ISOBMFF § 2.3.3 https://aomediacodec.github.io/av1-isobmff/#av1codecconfigurationbox-syntax
476477
#[derive(Debug)]
477478
pub struct AV1ConfigBox {
478479
pub profile: u8,
@@ -3046,6 +3047,7 @@ fn read_vpcc<T: Read>(src: &mut BMFFBox<T>) -> Result<VPxConfigBox> {
30463047
})
30473048
}
30483049

3050+
/// See AV1-ISOBMFF § 2.3.3 https://aomediacodec.github.io/av1-isobmff/#av1codecconfigurationbox-syntax
30493051
fn read_av1c<T: Read>(src: &mut BMFFBox<T>) -> Result<AV1ConfigBox> {
30503052
// We want to store the raw config as well as a structured (parsed) config, so create a copy of
30513053
// the raw config so we have it later, and then parse the structured data from that.
@@ -3560,7 +3562,8 @@ fn read_alac<T: Read>(src: &mut BMFFBox<T>) -> Result<ALACSpecificBox> {
35603562
Ok(ALACSpecificBox { version, data })
35613563
}
35623564

3563-
/// Parse a hdlr box.
3565+
/// Parse a Handler Reference Box.
3566+
/// See ISOBMFF (ISO 14496-12:2015) § 8.4.3
35643567
fn read_hdlr<T: Read>(src: &mut BMFFBox<T>) -> Result<HandlerBox> {
35653568
let (_, _) = read_fullbox_extra(src)?;
35663569

0 commit comments

Comments
 (0)