Skip to content

Commit 803ca39

Browse files
committed
Remove test_ffi and don't build mp4parse_capi as a dynamic library
These changes are necessary for conveniently vendoring into the mozilla-central tree since test_ffi requires a dynamic library to avoid duplicate symbols in the final binary, but certain builds fail in mozilla-central if the vendored in crates build as dynamic libraries. Since there is currently no way to parametrically disable building as a dynamic library via cargo, we will remove test_ffi and rely on the builds in the mozilla-central tree to alert us to API-breaking changes.
1 parent 62b1d4c commit 803ca39

File tree

8 files changed

+0
-358
lines changed

8 files changed

+0
-358
lines changed

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
members = [
33
"mp4parse",
44
"mp4parse_capi",
5-
"test_ffi",
65
]
76

87
[profile.release]

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ API is intended to wrap the rust parser. As such, features should primarily
1717
be implemented in the rust parser and exposed via the C API, rather than the C
1818
API implementing features on its own.
1919

20-
`test_ffi` builds and links `test_ffi/src/test.cc` into a small Rust test
21-
harness in `test_ffi/src/main.rs` that verifies the C API against the
22-
generated `mp4parse.h`.
23-
2420
## Tests
2521

2622
Test coverage comes from several sources:

mp4parse_capi/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ exclude = [
1919
"*.mp4",
2020
]
2121

22-
[lib]
23-
crate-type = ["lib", "cdylib"]
24-
2522
[badges]
2623
travis-ci = { repository = "https://github.com/mozilla/mp4parse-rust" }
2724

test_ffi/Cargo.toml

Lines changed: 0 additions & 13 deletions
This file was deleted.

test_ffi/build.rs

Lines changed: 0 additions & 39 deletions
This file was deleted.

test_ffi/include/mp4parse.h

Lines changed: 0 additions & 12 deletions
This file was deleted.

test_ffi/src/main.rs

Lines changed: 0 additions & 54 deletions
This file was deleted.

test_ffi/src/test.cc

Lines changed: 0 additions & 232 deletions
This file was deleted.

0 commit comments

Comments
 (0)