Merge pull request #137 from kinetiknz/issue136

rillian · web-flow · commit 77c1e14f6a10 · 2018-01-10T20:18:38.000-08:00
Remove `free_null_parser` test which incorrectly relied on panic! unwinding an FFI function.
diff --git a/mp4parse_capi/src/lib.rs b/mp4parse_capi/src/lib.rs
@@ -1141,14 +1141,6 @@ fn new_parser() {
     }
 }
 
-#[test]
-#[should_panic(expected = "assertion failed")]
-fn free_null_parser() {
-    unsafe {
-        mp4parse_free(std::ptr::null_mut());
-    }
-}
-
 #[test]
 fn get_track_count_null_parser() {
     unsafe {

Original file line number	Diff line number	Diff line change
`@@ -1141,14 +1141,6 @@ fn new_parser() {`
`1141`	`1141`	`}`
`1142`	`1142`	`}`
`1143`	`1143`
`1144`		`-#[test]`
`1145`		`-#[should_panic(expected = "assertion failed")]`
`1146`		`-fn free_null_parser() {`
`1147`		`- unsafe {`
`1148`		`- mp4parse_free(std::ptr::null_mut());`
`1149`		`- }`
`1150`		`-}`
`1151`		`-`
`1152`	`1144`	`#[test]`
`1153`	`1145`	`fn get_track_count_null_parser() {`
`1154`	`1146`	`unsafe {`