Bug 1690976 - Don't reveal error details for CORS-cross-origin decoding errors. r=sstreich,bryce, a=pascalc

Pehrsons · Pehrsons · commit ffc4ca160381 · 2021-02-08T11:43:36.000Z
Differential Revision: https://phabricator.services.mozilla.com/D104169
diff --git a/dom/html/HTMLMediaElement.cpp b/dom/html/HTMLMediaElement.cpp
@@ -5405,8 +5405,10 @@ void HTMLMediaElement::DecodeError(const MediaResult& aError) {
     }
   } else if (mReadyState == HAVE_NOTHING) {
     NoSupportedMediaSourceError(aError.Description());
-  } else {
+  } else if (IsCORSSameOrigin()) {
     Error(MEDIA_ERR_DECODE, aError.Description());
+  } else {
+    Error(MEDIA_ERR_DECODE, "Failed to decode media"_ns);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5405,8 +5405,10 @@ void HTMLMediaElement::DecodeError(const MediaResult& aError) {`
`5405`	`5405`	`}`
`5406`	`5406`	`} else if (mReadyState == HAVE_NOTHING) {`
`5407`	`5407`	`NoSupportedMediaSourceError(aError.Description());`
`5408`		`- } else {`
	`5408`	`+ } else if (IsCORSSameOrigin()) {`
`5409`	`5409`	`Error(MEDIA_ERR_DECODE, aError.Description());`
	`5410`	`+ } else {`
	`5411`	`+ Error(MEDIA_ERR_DECODE, "Failed to decode media"_ns);`
`5410`	`5412`	`}`
`5411`	`5413`	`}`
`5412`	`5414`